Comments (14)
pls look at the last line
from ebayui-core.
from ebayui-core.
- The leaf node goes to the next line - Raja will fix it
- Is ok for a new line to start with an arrow?-question to the design team
from ebayui-core.
PR is open - eBay/skin#130
from ebayui-core.
the fix broke mweb styling(looks fine in desktop)
from ebayui-core.
@hramakumar Which piece is broken? It's not immediately apparent from that screenshot. Can you provide a before and after?
@RajaRamu are you testing on mobile?
from ebayui-core.
breadcrumbs with leaf node as text look bigger that the ones with leaf as links
from ebayui-core.
- compare the first one"element with last page as current" and "element until end of line". the font size is different.
- Also if you look at "breadcrumb-two element" leaf element goes to the new line.
from ebayui-core.
@RajaRamu Can you investigate & provide more information on whether this is expected or not.
from ebayui-core.
I downgraded to skin version 3.5.1 and this issue goes away.
It has something to do with the skin upgrade 3.5.2(fix version)
from ebayui-core.
actual behavior
expected behavior
from ebayui-core.
@RajaRamu Can you please investigate.
from ebayui-core.
Yes. i will have to test it mobile devices. i will check it out in device lab. thanks
from ebayui-core.
Original issue was resolved.
from ebayui-core.
Related Issues (20)
- ebay-carousel: update icons to 16px
- button: partially-disabled attribute not working as expected.
- Need option to change current date in ebay-calendar component.
- ebay-notice-base: dismiss button is considered clicked when tabbing through it
- ebay-confirm-dialog freezes after hitting esc from keyboard
- snackbar-dialog: update docs to include CTA
- ebay-icon-button: add priority attributes
- Toggle button: Add additional states
- Eliminate `marko-tag.json` transforms where possible
- Add interface to allow client to pass data attribute to the component
- date-textbox: allow localized date formats
- 14.0.0 breaking changes
- ebay-lightbox-dialog/ebay-dialog-base: PrevButton missing Marko.AttrTag
- Close button not showing for <ebay-page-notice>
- ebay-listbox-button keyboard selection is scrolling
- ebay-chips-combobox: add custom text as an item to listbox
- DS Component: Data Table
- DS Component — Filter Bar
- ebay-date-textbox: not formatting date values correctly in input box for some locale input with country code
- ebay-Icon-button: aria-label is missing.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ebayui-core.