GithubHelp home page GithubHelp logo

Comments (14)

hramakumar avatar hramakumar commented on June 24, 2024

pls look at the last line

from ebayui-core.

hramakumar avatar hramakumar commented on June 24, 2024

arrow

from ebayui-core.

hramakumar avatar hramakumar commented on June 24, 2024
  1. The leaf node goes to the next line - Raja will fix it
  2. Is ok for a new line to start with an arrow?-question to the design team

from ebayui-core.

RajaRamu avatar RajaRamu commented on June 24, 2024

PR is open - eBay/skin#130

from ebayui-core.

hramakumar avatar hramakumar commented on June 24, 2024

the fix broke mweb styling(looks fine in desktop)
screenshot_2018-04-05-01-03-36

from ebayui-core.

ianmcburnie avatar ianmcburnie commented on June 24, 2024

@hramakumar Which piece is broken? It's not immediately apparent from that screenshot. Can you provide a before and after?

@RajaRamu are you testing on mobile?

from ebayui-core.

hramakumar avatar hramakumar commented on June 24, 2024

breadcrumbs with leaf node as text look bigger that the ones with leaf as links

from ebayui-core.

hramakumar avatar hramakumar commented on June 24, 2024
  1. compare the first one"element with last page as current" and "element until end of line". the font size is different.
  2. Also if you look at "breadcrumb-two element" leaf element goes to the new line.

from ebayui-core.

ianmcburnie avatar ianmcburnie commented on June 24, 2024

@RajaRamu Can you investigate & provide more information on whether this is expected or not.

from ebayui-core.

hramakumar avatar hramakumar commented on June 24, 2024

I downgraded to skin version 3.5.1 and this issue goes away.
It has something to do with the skin upgrade 3.5.2(fix version)

from ebayui-core.

hramakumar avatar hramakumar commented on June 24, 2024

actual behavior

skin_3 5 2

expected behavior

skin-3 5 1

from ebayui-core.

ianmcburnie avatar ianmcburnie commented on June 24, 2024

@RajaRamu Can you please investigate.

from ebayui-core.

RajaRamu avatar RajaRamu commented on June 24, 2024

Yes. i will have to test it mobile devices. i will check it out in device lab. thanks

from ebayui-core.

ianmcburnie avatar ianmcburnie commented on June 24, 2024

Original issue was resolved.

from ebayui-core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.