GithubHelp home page GithubHelp logo

New Component: Pill about ebayui-core HOT 4 CLOSED

ebay avatar ebay commented on June 24, 2024
New Component: Pill

from ebayui-core.

Comments (4)

msendlakowski avatar msendlakowski commented on June 24, 2024

@seangates @yomed
Based on our skin discussion we need a JS solution for line-clamp. This is something I created a while ago.

[redacted]

Do you have any other solutions or should I modify this for the component?

Also, whatever solution we come up with, I'm thinking to add it as a common utility. What do you think?

from ebayui-core.

seangates avatar seangates commented on June 24, 2024

👍 for common utility.

from ebayui-core.

ianmcburnie avatar ianmcburnie commented on June 24, 2024

I guess adding a pill boolean to ebay-button is the simplest way to go, but if there are going to be some button attributes not suitable or relevant to the pill, I wonder if it's worth creating an ebay-pill which acts as a simplified facade to ebay-button?

from ebayui-core.

seangates avatar seangates commented on June 24, 2024

Well, a lot of the attributes will be handled with state inside the ebay-pill component (e.g. checked state) so we wouldn't want to expose those the same was as the ebay-button. It's a button ... but more of a button type with limited button options.

So, I'm 100% in line with your thinking.

from ebayui-core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.