GithubHelp home page GithubHelp logo

Comments (3)

ArtBlue avatar ArtBlue commented on May 28, 2024

Older Safaris probably treat flex differently than new ones. Based on some initial brief troubleshooting, it looks like the dialogs may need some explicit styling, specifically, drawer-dialog--mask-fade (and other analogous elements for the other impacted components) may need the following mostly redundant/unnecessary styling for newer browsers, but crucial for older ones:

width: 100%;
height: 100%;
bottom: 0;
left: 0;

from skin.

mkchang avatar mkchang commented on May 28, 2024

Would it make sense to revert to

top: 0;
bottom: 0;
left: 0;
right: 0;

instead of inset: 0; for the dialogs, as changed in 1ac29fe? Since inset does not seem to be supported below Safari 14.

from skin.

ArtBlue avatar ArtBlue commented on May 28, 2024

@mkchang , thanks for tracking that down. I didn't realize this was a recent change that caused it. You're right, inset does not seem to be supported below Safari 14.1 so that reversion should work. I'll make sure before I create the PR.

from skin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.