canconvert doesn't extract value table of a multiplexor signal about canmatrix

[bomm]

In src/canmatrix/formats/dbc.py, function def dump(in_db, f, **options):, there is the following code to write value tables:

    # signal-values:
    for frame in db.frames:
        multiplex_written = False
        for signal in frame.signals:
            if signal.multiplex == 'Multiplexor' and multiplex_written:
                continue

            multiplex_written = True

            if signal.values:
                f.write(
                    ('VAL_ %d ' %
                     frame.arbitration_id.to_compound_integer() +
                     output_names[frame][signal]).encode(dbc_export_encoding, ignore_encoding_errors))
                for attr_name, val in sorted(signal.values.items(), key=lambda x: int(x[0])):
                    if '"' in val:
                        val = val.replace('"', '\\"')
                    f.write(
                        (' ' + str(attr_name) + ' "' + val + '"').encode(dbc_export_encoding, ignore_encoding_errors))

                f.write(";\n".encode(dbc_export_encoding, ignore_encoding_errors))

When I comment the lines

            if signal.multiplex == 'Multiplexor' and multiplex_written:
                continue

it seems to work with my DBC files.

I don't understand the purpose of the condition. As I understand the code, it will skip writing the value table for Multiplexor signals except if it is processed in the first loop iteration.
I don't know if there are any use cases where this change would have any bad effect.

[ebroecker]

Hi @bomm

thanks for this report.

I think this was a copy-paste error, but no idea...

could you try branch issue_704
which more or less does the same you did with commenting out...

pip install git+https://github.com/ebroecker/canmatrix.git@issue_704

Thanks