Invalid signature error in runtime tests about birt

[merks]

The signature files look different (have different names) with the latest signing service:

[merks]

I noticed this is the log:

[INFO]  [buildJar] load bundle uk.co.spudsoft.birt.emitters.excel from uk.co.spudsoft.birt.emitters.excel_4.17.0.v202407221948
Jul 23, 2024 7:42:35 AM org.eclipse.birt.build.pack.FrameworkPacker log
WARNING: duplicate org.eclipse.birt.chart.device.pdf/META-INF/CODESIGN.SF
Jul 23, 2024 7:42:35 AM org.eclipse.birt.build.pack.FrameworkPacker log
WARNING: duplicate org.eclipse.birt.chart.device.pdf/META-INF/CODESIGN.RSA

So indeed the new CODESIGN.* files are ending up in the runtime jar and are of course invalid. It's coincidentally convenient that yesterday I was cleaning up the org.eclipse.birt.build project which implements the ant tasks that builds the jar, so I know where to look to fix this...

[merks]

That being said, older successful showed this:

[INFO]  [buildJar] load bundle uk.co.spudsoft.birt.emitters.excel from uk.co.spudsoft.birt.emitters.excel_4.17.0.v202407201614
Jul 22, 2024 1:11:33 PM org.eclipse.birt.build.pack.FrameworkPacker log
WARNING: duplicate org.eclipse.birt.chart.device.pdf/META-INF/ECLIPSE_.SF
Jul 22, 2024 1:11:33 PM org.eclipse.birt.build.pack.FrameworkPacker log
WARNING: duplicate org.eclipse.birt.chart.device.pdf/META-INF/ECLIPSE_.RSA

Probably original the name was ECLIPSEF and was intended to be filtered out:

https://github.com/eclipse-birt/birt/blob/5f379b5b7dc7fffaff546b944adfe3ca1067aa08/build/org.eclipse.birt.build/src/org/eclipse/birt/build/ant/PackTask.java#L183C7-L186

I will try to enhance the filter.

[merks]

I noticed this now as well:

So the last time this was a problem, more than 9 years ago, it wasn't fixed by fixing the ant task implementation but by post-processing the jar produced by that task. Such a tangled web was woven...

[merks]

The above ant hack will also be cleaned up.

Thank goodness the tests for the runtimes were enabled, otherwise someone downstream would have noticed this at some later point in time, do doubt when it's least convenient rather than the day after the signing service was updated.

[merks]

The signature file names might be changed back to ECLIPSE_ but I already changed the pattern to accommodate that name as well:

"(.*\\.jar/)?META-INF/(ECLIPSEF|ECLIPSE_|CODESIGN)\\..*"

[hvbtup]

Ed, I really admire your endurance and your work...