target-async is deprecated about cdt

[jonahgraham]

Its all handled with my patch. stepSetNonStop is already overridden in FinalLaunchSequence_7_12

[jld01]

@Torbjorn-Svensson we don't use -gdb-set target-async on for GDB versions prior to org.eclipse.cdt.dsf.gdb.launching.FinalLaunchSequence_7_12 so it seems safe to modify stepSetTargetAsync to call a new stepSetMIAsync method within that class. If we modify org.eclipse.cdt.dsf.gdb.launching.FinalLaunchSequence_7_12.getExecutionOrder(String) to use the new step there is a possibility that we will break run-time behaviour of extenders that are modifying the execution order based on the position of stepSetTargetAsync, but CDT 11.0.0 seems a good time to make such a change.

[Torbjorn-Svensson]

Do you think we can keep the stepSetTargetAsync but leave the implementation empty and then add a new stepSetTargetAsync or would that still break run-time behavior for extenders?

I agree that CDT11 is a good time this type of change, but I don't know if the time has run out for doing it...

@jonahgraham WDYT? Is this something that we should do?

I'm slammed with work for the rest of the week, so if one of you could look at this (if it's something we want to do for CDT11), I'd appreciate it.

[jonahgraham]

Please have a look at #177 that fixes this.

[jonahgraham]

we don't use -gdb-set target-async on for GDB versions prior to

Actually we do, in non-stop mode in all versions of GDB:

cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/launching/FinalLaunchSequence.java

Line 405 in 1b19ba2

fCommandControl.queueCommand(fCommandFactory.createMIGDBSetTargetAsync(fCommandControl.getContext(), true),

[jld01]

we don't use -gdb-set target-async on for GDB versions prior to

Actually we do, in non-stop mode in all versions of GDB:

I missed that one. Could we override stepSetNonStop in FinalLaunchSequence_7_12? Or perhaps introduce a protected boolean hasGDBSetMIAsync() method in FinalLaunchSequence and override that in FinalLaunchSequence_7_12 ?

[jonahgraham]

cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/launching/FinalLaunchSequence_7_12.java

Line 148 in 1b19ba2

public void stepSetNonStop(final RequestMonitor requestMonitor) {