GithubHelp home page GithubHelp logo

Comments (6)

ruspl-afed avatar ruspl-afed commented on July 24, 2024

I would say that bundles like javax.xml should not be included to any CDT feature at all, but rather to the p2 site. This is required to let the "end-product" do decide which 3rd party version to include. For example, if 3rd party needs to be undated due to a fixed CVE.

from cdt.

Torbjorn-Svensson avatar Torbjorn-Svensson commented on July 24, 2024

I somewhat agree on the javax.xml, as they included in the CDT repository, but not built by us.
For org.eclipse.tools.templates.*, it's a different story as we (CDT) are building and providing these plugins.

from cdt.

ruspl-afed avatar ruspl-afed commented on July 24, 2024

I agree for org.eclipse.tools.templates.* and all others that CDT is building from its own sources, they definitely should belong to a CDT feature.

from cdt.

jonahgraham avatar jonahgraham commented on July 24, 2024

Not sure I understand what the bug is here.

Is it that we have bundles we depend on that aren't listed in feature.xmls? Do we need to open each feature.xml and in the Dependencies tab press Compute? Can this be automated as part of the build? Can tycho take this on as a feature request?

from cdt.

Torbjorn-Svensson avatar Torbjorn-Svensson commented on July 24, 2024

Not sure I understand what the bug is here.

Is it that we have bundles we depend on that aren't listed in feature.xmls? Do we need to open each feature.xml and in the Dependencies tab press Compute? Can this be automated as part of the build? Can tycho take this on as a feature request?

Yes, there is no feature.xml file that mentions the org.eclipse.tools.templates.* plugins, so there is no way to lock down these based on a given CDT release. The downstream consumer would need to know the internal plugin dependencies in order to lock down these plugins.

from cdt.

ruspl-afed avatar ruspl-afed commented on July 24, 2024

Not sure I understand what the bug is here.

We need to choose a concrete CDT feature to bring our org.eclipse.tools.templates.* plugins to the world

Is it that we have bundles we depend on that aren't listed in feature.xmls?

We do, and a lot of them, but I don't see an issue here.

Do we need to open each feature.xml and in the Dependencies tab press Compute?

Better to avoid this action, not sure that result will make us happy

Can this be automated as part of the build?

feature.xml is already a manifest for the automated build

Can tycho take this on as a feature request?

This is a kind of msiconfiguration on CDT side, nothing to do for Tycho here.

from cdt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.