Element order in project explorer arbitrarily changes if label decoration is involved about cdt

[jonahgraham]

Your explanation is reasonable and I would happily review a patch. However I think this is yet another case of where something from CDT started out as a copy of the JDT item (i.e. JavaElementSorter -> CElementSorter) but then didn't keep up with the changes. The important change that was "missed" was the JDT change of JavaElementSorter -> JavaElementComparator in eclipse-jdt/eclipse.jdt.ui@7e0c7e7 - can/should we make the same change - i.e. CElementSorter -> CElementComparator?

[jonahgraham]

In that case I will review #716 now and see if we can get that in for 2024-03 (CDT 11.5).

[travkin79]

Thank you for the hint, @jonahgraham. You might be right. That's quite a big commit. I have to check that.

[travkin79]

It seems, in eclipse-jdt/eclipse.jdt.ui@7e0c7e7 all occurrences of the obsolete JavaElementSorter (ViewSorter sub-class, ViewSorter is deprecated, too) are replaced with JavaElementComparator (ViewComparator). The main reason seems to be the removal of the org.eclipse.jface.viewers.ViewertSorter#getCollator() method from API. Since the ViewSorter subclasses ViewerComparator that seems to be just a kind of API clean-up.

Though, adopting that change in CDT likely requires quite many places to be changed. I suggest to create a separate issue / PR for that. Besides, I don't think, I could do that change shortly, since I'll be gone for one month beginning on 1. March.

[jonahgraham]

Thanks @travkin79 for the fix.

If you ever have other issues with the order and have time to do the CElementSorter -> CElementComparator change that would be great. Don't bother creating an issue unless there is an end user visible problem or a plan to fix it. (That is because if we created issues for all unplanned code cleanups with no user visible effect our issue tracker would sadly overflow)