GithubHelp home page GithubHelp logo

Comments (3)

jellypuno avatar jellypuno commented on May 30, 2024

The problem is because loadRepositories() is called during initialization. Inside this function it reads the settings.json and then calls the addSession() function if the profile is not added to the tree. I suggest 2 ways to handle this:

  1. remove loadRepositories in the the activation and put it somewhere else
  2. add a validation that if the profile found in setting.json and also found in allProfiles() then continue with addSession else ignore.

from che-che4z-explorer-for-endevor.

Alexandru-Dumitru avatar Alexandru-Dumitru commented on May 30, 2024

Thanks for looking into this, Jelly.

I would go with the second approach. It seems more straightforward as opposed to discussing the "where" we would move loadRepositories() and other associated implications.

Things to take into consideration (possible enhancements to the process):

  • should we add a warning so that the user is aware?
  • should we offer to auto fix this ? (can be even an options in endevor settings)
  • log these findings (miss-match between settings and actual profiles) in the output channel at least on trace level to help with debugging (really nice to have from the start)

from che-che4z-explorer-for-endevor.

jellypuno avatar jellypuno commented on May 30, 2024

This is already implemented in v0.12.1

from che-che4z-explorer-for-endevor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.