Support DS 1.4 + DS 1.5 in the Annotation processor about eclipse.pde

[HannesWell]

When enabling 1.4 I think it would be best to include 1.5 as well (unless there are major additional difficulties, I have not yet looked into the details):
https://search.maven.org/artifact/org.osgi/org.osgi.service.component.annotations

[laeubi]

Sure I have not yet checked what has changed between 1.3 -> 1.4 -> 1.5 maybe @tjwatson or @bjhargrave can give a short summary.

[bjhargrave]

DS 1.3 -> 1.4: https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.component.html#d0e46608

DS 1.4 -> 1.5: https://docs.osgi.org/specification/osgi.cmpn/8.0.0/service.component.html#d0e39795

[laeubi]

thanks for the doc reference, I have one question regarding constructor injection (maybe also just overseen that):

Ho is this supposed to work with annotation? Should a annotation processor simply assume that constructor injection is desired if there is a public non-default constructor?

[bjhargrave]

The constructor must be annotated @Activate and the constructor arguments which are not activation object types must be annotated @Reference.

See https://github.com/osgi/osgi/blob/b9f994ed76c755ebe2634465a27e46429ee0b836/org.osgi.impl.bundle.component.annotations/src/org/osgi/impl/bundle/component/annotations/ConstructorInjection.java#L49-L58 for a test example.

[laeubi]

Sounds obvious, thanks for the example!

[kwin]

Particularly useful are https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.component.html#org.osgi.service.component.propertytypes. Unfortunately there is no warning from PDE when those non-supported property type annotations are found. They are just silently ignored.

[HannesWell]

As suggested in #269 we could consider to use the PDE DS processor internally to generate the component XML.

But only if it is possible to get back errors/warnings from the BND-processor, so that they can be displayed in the java files.
This might be more work in the beginning but for future versions we can inherit the implementation work from BND.

[laeubi]

One limitation currently is that BND works on class-files only (I'm currently experimenting with using AST Parser and source files instead), so errors will only be reported after safe/compile/generate of the XML. Another drawback is that BND is currently not really very configurable in this regard, at Tycho I "trick" BND by generate the manifest and data into a intermediate directory and then analyze the Manifest to find the generated XMLs... far from optimal.

So having real Eclipse "while you type" support and suggestions, JDT/PDE is much more superior in this regards.

[laeubi]

Test execution requires

• eclipse-platform/eclipse.platform.releng.aggregator#1530