NoSuchElementException being thrown when showing old launch configs about eclipse.pde

[martinlippert]

If there is anything that I can provide to make the investigation of this easier, let me know. Since the data loss here is quite dramatic for someone working on plugin projects and having a bunch of launch configs with a specific set of plugins selected from the target platform and the workspace plugin project.

[vik-chand]

@HannesWell Can you please have a look?

[iloveeclipse]

Why do we want orElseThrow() at all? If I understand it right, we should simply return empty iterator

eclipse.pde/ui/org.eclipse.pde.launching/src/org/eclipse/pde/internal/launching/launcher/BundleLauncherHelper.java

Line 435 in 7eb3eab

IPluginModelBase latestModel = selectedModels.max(VERSION).orElseThrow();

[HannesWell]

Yes, I can take of this on thursday.And Andrey ist right, orElseThrow() should not be used here. An empty iterator could be returned if the Optional is empty, but I think the simplest way is to use Optional.stream(). @martinlippert could you please check if the old launch-config contains workspace-plugins that are absent or closed? And If removing the absent/closed entries avoids the exception.

[HannesWell]

Looks like Github as detected the interesting part of my reply send via mail as an E-Mail an obfuscated it. I have edited it.

PR #93 should fix the problem. Feel free to have a look.
It also adds a test-case that should reproduce your problem and fails without the fix and passes with it.

[martinlippert]

Yes, I can take of this on thursday.And Andrey ist right, orElseThrow() should not be used here. An empty iterator could be returned if the Optional is empty, but I think the simplest way is to use Optional.stream(). @martinlippert could you please check if the old launch-config contains workspace-plugins that are absent or closed? And If removing the absent/closed entries avoids the exception.

Yes, I checked this again and you can easily reproduce this error using these steps:

• open Eclipse with empty workspace
• import a plugin project
• create a launch config where this plugin from the workspace is selected (so switch to the mode where you select individual plugins)
• close the launch config dialog
• delete the plugin project from the workspace
• open the launch config again, it will immediately throw the exception

Many thanks @HannesWell for taking a look and implementing a fix for this. Very much appreciated!!!

[HannesWell]

Many thanks @HannesWell for taking a look and implementing a fix for this. Very much appreciated!!!

You are very welcome and thank you for checking!
The fix should be available in next I-build. If possible please verify that the problem is really solved.

[HannesWell]

Verified with Eclipse SDK

Version: 2022-06 (4.24)
Build id: I20220516-1800

[martinlippert]

Tested my setup with the latest fixes, works all well again. Many many thanks again @HannesWell !!!

[HannesWell]

Great. :)
You are welcome and thanks for the bug report.