Disable or fix System theme on Windows about eclipse.platform.ui

[mickaelistria]

System theme looks better on Linux. I use it all the time and the feedback is positive, it also better adapts to system theme than no theme at all. So no, let's not retire. Instead, one can fix how it looks on WIndows.

[vogella]

@mickaelistria what about if me made is special for Linux? I don't think you plan to fix it under windows neither do I and it looks broken.

[vogella]

Tbh. you should have done this for the default light theme in Linux instead of starting a new theme.

[mickaelistria]

It's not special to any OS, it's following the color constants retrieved by SWT for the current system. The default light theme use color constants and does not adapt to native theme changes; and the system theme may actually be dark, or green, or light and Eclipse would react.
Ideally, the best would be no theme at all, but things like multiple CTabFolders to identify which folder has focus require a theme at the moment.
That said, if you don't want that theme to be visible under Windows, feel free to add the necessary flags for it. I wouldn't mind. But retiring this theme, I certainly mind, a lot.

[mickaelistria]

I've thought a bit more about it, as I agree 1 goal is to remove the System theme all together and replace it with native. The blocking issue is the default CTabRendering of e4 that makes it hard to find out which current CTabFolder has focus. I'll try to keep it in mind and hopefully will be able one day to improve that in SWT directly.
I've reported eclipse-platform/eclipse.platform.swt#55 to SWT to fix this problem at its root. When it's fixed, I think we can just remove the System theme and use no theme instead.

[vogella]

I was trying to reduce the styling to only style the tab folder but only styling the tab results in an endless loop, see #4

[mickaelistria]

I plan to remove the System theme as soon as eclipse-platform/eclipse.platform.swt#183 is merged.

[vogella]

Windows looks really good with the forms fix and theming disabled. @mickaelistria do you still plan to delete the system theme, or do you still need it for Linux?

[mickaelistria]

In any case, I think it's better to remove it and focus attention on SWT itself. I don't plan to maintain the System theme further. So I will try to remove it soon-ish.

[mickaelistria]

See #142