Comments (9)
Thanks for reporting the behaviour on MacOS.
On Linux, the issue is somewhat similar: Even if you have Eclipse set to a Light theme, the workspace launcher will use the GTK theme, which may or may not be dark.
I think the issue might be more difficult to fix on Linux than OSX since it is GTK theme dependant, however I'm not sure.
from eclipse.platform.ui.
so there is no way we can predict the theme for the workspace launcher dialog:
Eclipse stores the last used workspace so one could use the theme of the most recent workspace if its really important for the workspace chooser dialog to be "styled" but I'm not sure if styling is even available at this stage.
from eclipse.platform.ui.
@davidsoles are you selecting the OS dark theme or the dark theme of Eclipse?
from eclipse.platform.ui.
@vogella I'm selecting the dark theme of Eclipse.
from eclipse.platform.ui.
Unfortunately the theme engine is only available after the workspace has been selected. PartRenderingEngine#run calls initializeStyling in line 1050 after ChooseWorkspaceDialog. So if we want to style the workspace selection screen we would have to enable the styling engine before. Not sure how much effort that would be but if you want to analyse and send a PR that would be great.
from eclipse.platform.ui.
Isn't the theme stored as a preference in the workspace? I think so, hence each workspace can have a different theme and you don't know the theme until after a specific workspace has been chosen...
from eclipse.platform.ui.
Would be best to not store the preference in workspace then :-) Or to use the theme of the last used workspace.
I currently use two workspaces with different themes to know which workspace i am in. But that's not an important feature.
from eclipse.platform.ui.
Isn't the theme stored as a preference in the workspace? I think so, hence each workspace can have a different theme and you don't know the theme until after a specific workspace has been chosen...
@merks - you are right, the theme is stored in the workspace, so there is no way we can predict the theme for the workspace launcher dialog:
cat $WORKSPACE/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.e4.ui.css.swt.theme.prefs
eclipse.preferences.version=1
themeid=org.eclipse.e4.ui.css.theme.e4_dark
looks like a chicken & egg problem to me!
from eclipse.platform.ui.
FWIW, on Linux (or on GTK with other OS by the way), lower-level SWT, and thus the workspace launcher dialog widget as well, can be fully themed by relying on GTK themes, see for example https://eclipse.dev/eclipse/news/4.18/platform.php#system-theme . Launching an application such as Eclipse IDE with a different GTK theme is only a matter of setting a I_DONT_REMEMBER_WHICH_ONE environment variable and then you get full theming.
from eclipse.platform.ui.
Related Issues (20)
- [Generic Editor] Restore from Local History shows no file content and throws an exception
- e4: FinishedJobs instance is never injected into ProgressServiceImpl for progress dialogs HOT 3
- Changed tab icons are not saved in workbench.xmi
- Random failure of WorkbenchPluginTest.testGetImageRegistryFromAdditionalDisplay()
- Resource Properties Dialog to small to see buttons HOT 3
- e4: Add a way to provide translations to ProgressMessages HOT 11
- The tool bar items of Debug perspective ticking in other perspectives HOT 1
- Registering Link Handlers on Signed macOS Eclipse Installation breaks Eclipse Installation HOT 7
- Min-Max area too large in no editor is open HOT 7
- Refresh option only available for projects HOT 6
- Some way to pin a Debug Inspect window HOT 17
- [Find/Replace Overlay] The search-history cannot be accessed from the Overlay
- [find/replace dialog] remove Ringtone HOT 1
- [find/replace overlay] Add Editor-Annotations whereever a search-result was found
- [find/replace overlay] Overlay option buttons are not accessible via tab.
- [find/replace overlay] it is not intuitive that enabling RegEx disables Incremental Search
- [find/replace overlay] Separate UI from Controller Logic HOT 2
- [find/replace logic] cannot easily reset the Incremental Base-Location
- [find/replace overlay] incremental base position resets randomly when using "search in selection"
- [find/replace overlay] disabling RegEx resets to the wrong base-location
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eclipse.platform.ui.