Comments (3)
This is a very generic issue. We should open individual issues for each of the diagnostics (similar to how we did for Servlet)
from lsp4jakarta.
There is not many use cases where users are extending a class and that I must check for the existence of some extending class in the class def. Rather I believe the diagnostics I will need on annotations will be related to imports.
So I will be creating Annotation diagnostics for the following:
@Entity
@NamedQuery
@PersistenceContext
@Table
@Column
@Id
@Transient
@OneToOne
@OneToMany
... Any others that we need
So the idea is that I will perform a diagnostic checking first for the jakarta.persistence.*
import. But if that is not present then I will search more granularly for annotation specific imports.
Once we have decided if these are worth doing then I can open up more detailed issues individually.
This problem would be solved using the current framework of building a jakarta persistence collector in the language server that tests for all of these annotations
Technically for coverage I can perform this for every single annotation in the spec, at section 11 of the spec. Would eclipse be able to tell from which package this annotation is coming from? If not I can implement all of the annotations with their respective import packages required
from lsp4jakarta.
I don't think it's necessary that we implement our own diagnostics for correcting the imports as the Java Language Server already offers this capability
from lsp4jakarta.
Related Issues (20)
- Please provide a p2 repository to install the eclipse plugin
- jakarta faces and servlet support
- Enhancement to dynamically use test project for "no diagnostics" automated tests
- JSF / Faces Suggestions
- Classname not populated from filename when using snippet completion
- Missing codeAction Tests in ResourceClassConstructorTest.java File HOT 2
- Investigate whether LSP4Jakarta consistently processes fully qualified class names. HOT 2
- Should the JakartaProjectLabelProvider return finer grained labels?
- Missing codeAction Tests in JakartaServletTest.java file
- Design Consideration for quick fixes with multiple parameters to ensure they fully resolve errors
- Latest release of Eclipse JDT breaks diagnostics due to usage of internal JDT class HOT 1
- org.eclipse.lsp4jakarta.commons.JavaCursorContextKind.forValue() throws an IllegalArgumentException when passed the value from its own NONE constant. HOT 1
- Tests for InsertImplementsClauseToImplFilterQuickFix and InsertImplementsClauseToImplListenerQuickFix is not available in lsp4jakarta
- Multiple `@BeanParam`s incorrectly reported as error
- Only reports one error when two exist in Bean Validation HOT 1
- Diagnostic missing for `@PositiveOrZero` HOT 2
- Error in Readme doc for Json binding and others
- Support Diagnostics in Java Record fields for Jakarta Validation HOT 1
- Implementations of interfaces should be allowed for Validation annotations HOT 1
- Add unit tests for certain quick fixes HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lsp4jakarta.