GithubHelp home page GithubHelp logo

Comments (3)

kathrynkodama avatar kathrynkodama commented on July 29, 2024

This is a very generic issue. We should open individual issues for each of the diagnostics (similar to how we did for Servlet)

from lsp4jakarta.

AnkushSharma2698 avatar AnkushSharma2698 commented on July 29, 2024

There is not many use cases where users are extending a class and that I must check for the existence of some extending class in the class def. Rather I believe the diagnostics I will need on annotations will be related to imports.

So I will be creating Annotation diagnostics for the following:

@Entity
@NamedQuery
@PersistenceContext
@Table
@Column
@Id
@Transient
@OneToOne
@OneToMany
... Any others that we need

So the idea is that I will perform a diagnostic checking first for the jakarta.persistence.* import. But if that is not present then I will search more granularly for annotation specific imports.

Once we have decided if these are worth doing then I can open up more detailed issues individually.

This problem would be solved using the current framework of building a jakarta persistence collector in the language server that tests for all of these annotations

Technically for coverage I can perform this for every single annotation in the spec, at section 11 of the spec. Would eclipse be able to tell from which package this annotation is coming from? If not I can implement all of the annotations with their respective import packages required

from lsp4jakarta.

kathrynkodama avatar kathrynkodama commented on July 29, 2024

I don't think it's necessary that we implement our own diagnostics for correcting the imports as the Java Language Server already offers this capability

from lsp4jakarta.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.