GithubHelp home page GithubHelp logo

Comments (4)

arthurdm avatar arthurdm commented on July 2, 2024 1

Although it's true that the above code seems reasonable for the usage of ref, I don't necessarily agree that we should make Parameter a constructible model because that would mean someone could build OASFactory.createObject(Parameter.class) (i.e. a parameter without a specified in) and give that back via the filter or model reader.

I vote that we keep the current models, and if someone wants to build a Parameter reference just use the instance of the target reference, for example: OASFactory.createObject(HeaderParameter.class).ref("myParam2").

The javadoc of ref already states that its usage prevents any of the other methods from the class from being valid, so we're ok.

@EricWittmann - thoughts on this, as you have been building some models?

from microprofile-open-api.

EricWittmann avatar EricWittmann commented on July 2, 2024

I agree with Arthur with an H. 😀

from microprofile-open-api.

arthurdm avatar arthurdm commented on July 2, 2024

Cool - closing this one then. @arturdzm - thanks for bringing this up. It was a valid discussion.

from microprofile-open-api.

arturdzm avatar arturdzm commented on July 2, 2024

Sure, sounds good to me.

from microprofile-open-api.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.