Comments (8)
Everything is currently fine on CRAN. Did you notice any trouble with Boost 1.78?
from bh.
:waves back: - googlePolylines
is currently all OK on CRAN. Let me know if the reverse depenency checks give me any grief and I'll update as well.
from bh.
I appreciate you working through this.
At present, CRAN has other packages where R-oldrel fails on Windows because of the toolchain. Nobody is really complaining. Come April and R 4.1.0, the current rtools4
toolchain with gcc-8
and g++-8
will become old-rel. The current r-devel also just switched to C++14 as the default compilation (where available, this would include Windows if I am not mistaken), and my inclination is actually to ... simply sit pat and wait this out.
What you did (including your modified headers before the official one, and relying on the include to prevent overwriting your definitions) is good. Maybe #undef`-ing the include guard and doing the include afterwards is better if other definitions are needed -- I don't know.
from bh.
I know that it is not a big deal and the CRAN does not complain about it. But I believed that the old toolchain will still live for longer than that. I didn't know that it will be retired in April. My patch suddenly becomes less valuable 😞 . Anyway I'm sure lot of people still use R 3.6...
On my side I still have clang-USBAN + Solaris errors. The Solaris error comes out of nowhere, is not directly linked to lidR but seems to be caused by old libraries (gdal
and proj
) and I can't reproduce it. Because I can't fix Solaris error I tried to fix the windows-oldrel in attempt to get more chance to get my next minor update accepted... 🎲 Anyway, in the worst case I learned a lot doing so. Nothing lost.
By the way the good way to target gcc < 5 specifically seems to be
#if defined(__GNUC__) && (__GNUC__ < 5) && !defined(__clang__) && !defined(__llvm__) && !defined(__INTEL_COMPILER)
because clang
defines __GNUC__
(SO question)
from bh.
Hi @Jean-Romain just checking in as I will likely work on Boost 1.78 in the next few days preparing a release. From checking lidR
and rlas
at CRAN, everything seems peachy now without issue stemming from package BH
-- correct?
(And ditto for googlePolyline
-- 👋 at @dcooley ?)
from bh.
Have not gotten to it -- have to mark student projects this weekend. Should get to it by Monday and run reverse depends checks hopefully early next week.
from bh.
Sounds good. I have the package ready, but the reverse-depends box is currently tied up with another Rcpp run. Will get to BH 1.78.0 tomorrow but do not expect any trouble.
from bh.
I think we can close this as the old issue (for 1.75.0) it was raised for got sorted (as "promised") with the disappearance of the older build platform, and neither 1.75.0 or now 1.78.0 seem to pose issue. Yay for good code.
from bh.
Related Issues (20)
- BH 1.84.0 CRAN Release Planning HOT 2
- boost::geometry compilation failing with LLVM 19 HOT 2
- Include Boost Beast in next upstream update HOT 21
- Update BH to 1.75.0 and minor regressions requiring downstream changes HOT 37
- Include boost process? HOT 8
- Include boost ublas? HOT 3
- Upgrade to Boost 1.78 HOT 11
- Add Boost::Lambda2 ?
- Installation error r-devel-linux-x86_64-debian-gcc HOT 24
- A request to add timer/include/boost/progress.hpp HOT 11
- Compilation of `bigmemory` fails in Alpine Linux apparently due to BH version HOT 2
- BH 1.81.0 upgrade plan HOT 10
- CRAN warning "Found 'sprintf', possibly from 'sprintf' (C)" using BH HOT 5
- Compile failure of BH as a dependency of https://github.com/steven-shuken/permFDP HOT 4
- clang16 compatibility under C++17 HOT 6
- Undefined reference to `scoped_static_mutex_lock` on Windows R 3.6 HOT 1
- system.file("include", package = "BH") returns empty string HOT 4
- Current version breaks CRAN checks HOT 7
- QVM support HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bh.