Adjust brightness of some colors in bright theme version about nightfox.nvim

[EdenEast]

Thanks for the feedback. I was not sure about the yellow when I was making the theme but could not come up with a color that I was happy with. Yellow with a light theme is hard to get right. This has prompted me to look at other light themes (as I normally only user dark themes). From what I have gathered the good ones don't use yellow if at all. If yellow is used it is for something small. The theme file was written for nightfox and for dark themes without thinking about light themes. Here are some of my current thoughts.

• Update the theme.lua file for syntax highlight groups that are currently defined as yellow change that to some other color like (red? or pink?)
• Change the actual definition of yellow to be another color. Not sure what that color would be but a shade of another color.
  • This is similar to how dawn/dusk don't define a green it is more of an orange (The color is called New York Pink.... 😕)
• Darken the yellow and change orange to some shade of brown.
• Darken the background color just a bit. Change it to something more like #E5E5E5 (This would also remove the slight blue tint to the bg and make r, g, and b the same value)

Would be interested in hearing someone else's thoughts on this.

[EdenEast]

I might have something with the attached pr. Let me know if this is a better direction.

[JoseConseco]

It looks better. Here is comparison of github light theme:

vs dayfox:

Its not as clear as github theme but close.