Comments (5)
Of course, that makes perfect sense not to change the implementation. Having this in mind, I still think that using some other word in the public API would be a nicer and more idiomatic way of using the library.
If you're fine with this, I could try to make a PR with the changes soon.
from verk.
One very important feature that Verk has is the compatibility with Sidekiq/Reque clients. They use the term class
and that's why we follow the same convention. We could potentially convert through Verk.enqueue
, Verk.schedule
so that our client will talk about "modules" but the underlying implementation should stay as class
from verk.
yeah definitely would like to accept it from our client 👍
We would still need to accept class
or module
. Thanks for starting this!
from verk.
Late to the discussion on this but I'm not in support of a change to the documentation on this. Possibly open to it with convincing documentation that the naming is causing confusion. But as it stands we don't really benefit from adding an additional option for job enqueueing.
The downside is that we have to do additional work to support a new enqueuing option with the same functionality and we will have to still mention the class
term because not including it in the documentation would be confusing to those who plan to enqueue jobs from resque.
from verk.
I'm closing this as there's no agreement and no real gain to change this.
from verk.
Related Issues (20)
- Strange behaviour with integer argument, potential bug HOT 17
- Add mix task to reset queues HOT 9
- Add pending jobs to queue stats HOT 2
- Unable to overwrite `max_retry_count` via config.exs HOT 2
- Event for dead job HOT 2
- Question. Can Verk check more frequently for new jobs? HOT 2
- Undocumented `max_dead_jobs` HOT 1
- function Verk.Supervisor.start_link/1 is undefined or private HOT 3
- Im surely missing something. HOT 4
- Coupling of producers and consumers? HOT 1
- Upgrade GenStage to current version HOT 5
- Version Conflict with Confex 3.4.0 HOT 2
- Loosen dependency on redis HOT 2
- Verk 2.0 HOT 12
- Skip queuing jobs during tests. HOT 1
- Batch processing? HOT 2
- Defining contextual data for worker processes HOT 4
- [question] What are the risks of the "experimental" generate_node_id feature? HOT 4
- How do I setup Verk as a producer only? HOT 1
- Connect to Redix via ipv6? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from verk.