GithubHelp home page GithubHelp logo

Comments (5)

mkaszubowski avatar mkaszubowski commented on August 27, 2024 2

Of course, that makes perfect sense not to change the implementation. Having this in mind, I still think that using some other word in the public API would be a nicer and more idiomatic way of using the library.

If you're fine with this, I could try to make a PR with the changes soon.

from verk.

edgurgel avatar edgurgel commented on August 27, 2024

One very important feature that Verk has is the compatibility with Sidekiq/Reque clients. They use the term class and that's why we follow the same convention. We could potentially convert through Verk.enqueue, Verk.schedule so that our client will talk about "modules" but the underlying implementation should stay as class

from verk.

edgurgel avatar edgurgel commented on August 27, 2024

yeah definitely would like to accept it from our client 👍

We would still need to accept class or module. Thanks for starting this!

from verk.

keyan avatar keyan commented on August 27, 2024

Late to the discussion on this but I'm not in support of a change to the documentation on this. Possibly open to it with convincing documentation that the naming is causing confusion. But as it stands we don't really benefit from adding an additional option for job enqueueing.

The downside is that we have to do additional work to support a new enqueuing option with the same functionality and we will have to still mention the class term because not including it in the documentation would be confusing to those who plan to enqueue jobs from resque.

from verk.

edgurgel avatar edgurgel commented on August 27, 2024

I'm closing this as there's no agreement and no real gain to change this.

from verk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.