Comments (11)
@edgurgel i've got it mostly done now, but having a hard time figuring out how to get meck
to work. Its not a library I've used before, and in general I try to avoid that kind of mocking so not sure what needs to change to get those tests passing. I'm sure I've made worse whatever my original testing issue was, but maybe you can take a look at it and see. I'll try to get the work I did today to remove Timex pushed up tonight or tomorrow morning on #79.
from verk.
Would dropping Timex in favor of standard Elixir/Erlang times be something to consider if it's a breaking change anyway?
from verk.
I think its worth considering, though its not just a matter of the date/time structs, which AFAIK is primarily what elixir standardized in 1.3. Timex also adds niceties for dealing with things like durations and timezones that can still be a PITA with the stock functions. That said, I think the primary use of datetimes in Verk is to mark when jobs were enqueued and whether enough time has passed, which can probably done with the standard library functions.
from verk.
Reviewing the usages of Timex, the primary utility is to get the current unix time, which can easily be replaced by standard lib. There are a couple of ancilliary uses of Timex.shift
and Timex.compare
which could be abstracted away if maintainers feel like dropping the dependency is worthwhile. My 2 cents is to be generally in favor of killing dependencies when the utility of them is shallow, as I think it is in this case.
from verk.
Thanks @mitchellhenke and @karmajunkie. I would be keen to move to ~> 1.3
and remove Timex from our dependencies. What do you folks think?
@karmajunkie, would you be interested in creating a PR? I can definitely work on this till the end of the week (2-3 days from now).
Seems legit?
Then I will just need to update Verk Web to either work with Timex 3 or use standard Elixir :)
from verk.
Not part of this work but I will also use this moment to move to Poison 2 and remove this code https://github.com/edgurgel/verk/blob/master/lib/verk/poison_version.ex
from verk.
That sounds super to me
On Mon, Sep 19, 2016 at 10:51 PM Eduardo Gurgel [email protected]
wrote:
Not part of this work but I will also use this moment to move to Poison 2
and remove this code
https://github.com/edgurgel/verk/blob/master/lib/verk/poison_version.ex—
You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub
#78 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABXTq0_abD2o9ID0C_hbmj4v4kqrZ5V0ks5qr1hXgaJpZM4KApGn
.
from verk.
Cool I will take a look at this today! Thank you again for starting this :)
from verk.
Closing this as #79 was merged in, resolving the issue
from verk.
Awesome! I will update Poison and others libs then release a new major version! Thanks again :)
from verk.
Verk 0.13.0 is out https://github.com/edgurgel/verk/releases/tag/v0.13.0 https://hex.pm/packages/verk/0.13.0
Thanks!
from verk.
Related Issues (20)
- Strange behaviour with integer argument, potential bug HOT 17
- Add mix task to reset queues HOT 9
- Add pending jobs to queue stats HOT 2
- Unable to overwrite `max_retry_count` via config.exs HOT 2
- Event for dead job HOT 2
- Question. Can Verk check more frequently for new jobs? HOT 2
- Undocumented `max_dead_jobs` HOT 1
- function Verk.Supervisor.start_link/1 is undefined or private HOT 3
- Im surely missing something. HOT 4
- Coupling of producers and consumers? HOT 1
- Upgrade GenStage to current version HOT 5
- Version Conflict with Confex 3.4.0 HOT 2
- Loosen dependency on redis HOT 2
- Verk 2.0 HOT 12
- Skip queuing jobs during tests. HOT 1
- Batch processing? HOT 2
- Defining contextual data for worker processes HOT 4
- [question] What are the risks of the "experimental" generate_node_id feature? HOT 4
- How do I setup Verk as a producer only? HOT 1
- Connect to Redix via ipv6? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from verk.