Timex 3 support about verk

[karmajunkie]

@edgurgel i've got it mostly done now, but having a hard time figuring out how to get meck to work. Its not a library I've used before, and in general I try to avoid that kind of mocking so not sure what needs to change to get those tests passing. I'm sure I've made worse whatever my original testing issue was, but maybe you can take a look at it and see. I'll try to get the work I did today to remove Timex pushed up tonight or tomorrow morning on #79.

[mitchellhenke]

Would dropping Timex in favor of standard Elixir/Erlang times be something to consider if it's a breaking change anyway?

[karmajunkie]

I think its worth considering, though its not just a matter of the date/time structs, which AFAIK is primarily what elixir standardized in 1.3. Timex also adds niceties for dealing with things like durations and timezones that can still be a PITA with the stock functions. That said, I think the primary use of datetimes in Verk is to mark when jobs were enqueued and whether enough time has passed, which can probably done with the standard library functions.

[karmajunkie]

Reviewing the usages of Timex, the primary utility is to get the current unix time, which can easily be replaced by standard lib. There are a couple of ancilliary uses of Timex.shift and Timex.compare which could be abstracted away if maintainers feel like dropping the dependency is worthwhile. My 2 cents is to be generally in favor of killing dependencies when the utility of them is shallow, as I think it is in this case.

[edgurgel]

Thanks @mitchellhenke and @karmajunkie. I would be keen to move to ~> 1.3 and remove Timex from our dependencies. What do you folks think?

@karmajunkie, would you be interested in creating a PR? I can definitely work on this till the end of the week (2-3 days from now).

Seems legit?

Then I will just need to update Verk Web to either work with Timex 3 or use standard Elixir :)

[edgurgel]

Not part of this work but I will also use this moment to move to Poison 2 and remove this code https://github.com/edgurgel/verk/blob/master/lib/verk/poison_version.ex

[mitchellhenke]

That sounds super to me
On Mon, Sep 19, 2016 at 10:51 PM Eduardo Gurgel [email protected]
wrote:

Not part of this work but I will also use this moment to move to Poison 2
and remove this code
https://github.com/edgurgel/verk/blob/master/lib/verk/poison_version.ex

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#78 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABXTq0_abD2o9ID0C_hbmj4v4kqrZ5V0ks5qr1hXgaJpZM4KApGn
.

[edgurgel]

Cool I will take a look at this today! Thank you again for starting this :)

[karmajunkie]

Closing this as #79 was merged in, resolving the issue

[edgurgel]

Awesome! I will update Poison and others libs then release a new major version! Thanks again :)

[edgurgel]

Verk 0.13.0 is out https://github.com/edgurgel/verk/releases/tag/v0.13.0 https://hex.pm/packages/verk/0.13.0
Thanks!