Why are ExtraStorage crafters showing `Current Speed (limited by machinery)` when regular crafters don't such a limitation? about extrastorage

[credomane]

I must have imagined editing my original post to put some text in the "anything else" section to ask exactly how the limited by machinery is being determined. Thanks for explaining that. Anyways, I did some more testing myself and found a few mistakes on my end that were severely slowing down processing in my actual setup. Thus causing the Extra Storage crafters to appear just as slow or slower than RS Crafters despite there being a 22x speed difference. I was initially chasing a red herring because of it.

the crafter could go much faster but the number of slots the machinery has is less than the speed

So that's how that limit is determined. That makes perfect sense. I can work with that to improve performance of my particular processing setup. Thanks again! Time to swap out the chests for Diamond chests it is then.

I know you've made a code change already to add a config value for this particular "limitation" but would it also be possible to update the tooltip to indicate it is limited by the machinery's inventory slots? The way it reads now I was actually taking it to be some odd/bad mod interaction/incompatability issue the whole time. As the chests I was using for the 27x limitation are actually from the quark mod. Never thought to convert Quark's Oak Chest into a vanilla chest for some reason as see if the 27x limit stayed.

[Edivad99]

The number of processed items of the crafter is determined by the getMaximumSuccessfulCraftingUpdates method.
In the RS, this method returns the number of SpeedUpgrades + 1, therefore at most 5.
When the wording "limited by machinery" comes up, it means that the crafter could go much faster but the number of slots the machinery has is less than the speed and the crafter does not insert more than x items. This was done to speed up the machinery of the mekanism.
I did a test with a vanilla chest and the extrastorage crafters are faster than the RS ones

@Override
  public int getMaximumSuccessfulCraftingUpdates() {
    int speed = getTierSpeed();
    if (hasConnectedInventory()) {
      return Math.min(speed, getConnectedInventory().getSlots());
    }
    return speed;
  }

  public int getTierSpeed() {
    int upgradesCount = upgrades.getUpgradeCount(UpgradeItem.Type.SPEED);
    if (tier.equals(CrafterTier.IRON)) {
      return upgradesCount + tier.getCraftingSpeed();
    }
    return (upgradesCount * (tier.getCraftingSpeed() / 5)) + tier.getCraftingSpeed();
  }

[Edivad99]

With this commit (409d7d8) I leave the choice to the user if he wants the uniform distribution or the maximum speed. Unfortunately you can't both.