GithubHelp home page GithubHelp logo

Turnover Time Defaults about ed2 HOT 4 OPEN

edmodel avatar edmodel commented on June 3, 2024
Turnover Time Defaults

from ed2.

Comments (4)

apourmok avatar apourmok commented on June 3, 2024

If I recall correctly, last year Jaclyn Matthes found the same problem and fixed it in her branch but not sure if she pushed that in to mainline.

from ed2.

crollinson avatar crollinson commented on June 3, 2024

I was just looking at some of the outputs from our runs and our heterotrophic respiration is super high as well, so I just made a commit with Jackie's changes that Afshin was referring to. From my understanding these are from a meta-analysis from Moyano et al 2012 in Biogeosciences. You can scope out the changes here: crollinson@ab62e09

However, I think my problem may actually be linked to not having the system solved for steady-state correctly, but I'll leave the changes in place for now. I think the idea at the time was to allow this to be another option for decomp scheme and it was just never fully implemented.

from ed2.

DanielNScott avatar DanielNScott commented on June 3, 2024

@apourmok it would seem she didn't, since the quoted code is in the mainline.

@crollinson Interesting... with too-high parameters the model can only develop respiratory CO2 at the rate of substrate input which, if the forest C pools are in steady state (@ harvard they're presumed to be, except the very old ones) is the rate it would be developing CO2 anyway. This would lead me to believe that if your resp is too high, and you aren't accumulating an unreasonable amount of fast soil C that you have too much input.

Thanks for the link to the different scheme, it does look like it would make sense potentially to add another case (but probably not to simply replace the default!) although we have so many options in the ED2IN it's already difficult to know what to make of many of them. I think an accounting of the various options and when/why they should be used or when/why they provide better results is in order for ED generally...

Anyway, I'm not actually sure all that's super relevant to this thread, or maybe I'm just missing it. The real question is, do we think as a community it's wise to have the default slow soil carbon turnover at 10 times the rate of fast soil carbon(!)? I suspect the answer is no.

from ed2.

mpaiao avatar mpaiao commented on June 3, 2024

@DanielNScott I agree with you, we should have reasonable default numbers for the decay rates for all cases. For reference, below is the paper Paul suggested me to look at when I found this bug sometime in 2012. I couldn't find any reason for the rate to be 100.2 (for example, check their Fig. 3). It's probably just a typo that somehow has survived in the code since ED-1...

B. M. Bolker, S. W. Pacala, and W. J. Parton. Linear analysis of soil decomposition: insights from the CENTURY model. Ecol. Appl., 8(2):425–439, May 1998. http://dx.doi.org/10.1890/1051-0761(1998)008[0425:LAOSDI]2.0.CO;2

from ed2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.