Running install with the current version causes a problem with disturbance file about ed2

[Viskari]

Hello once again,

After going through the code in more detail, the problem is caused by the following if statement submitted by Markos at the end of last year. Now I can easily get past this problem, but I am checking as I am not completely certain what the if statement is supposed to be checking for as far as I can tell it is only checking the pft against one pft in the patch.

                                if ( include_pft(ipft) == cpatch%pft(1) ) then
                                   !---------------------------------------------------!
                                   !    PFTs match, send all disturbed area to this    !
                                   ! patch.                                            !
                                   !---------------------------------------------------!
                                   same_pft = .true.
                                   area_fac = act_area_loss(ipa,new_lu)/csite%area(npa)
                                   !---------------------------------------------------!
                                else
                                   !---------------------------------------------------!
                                   !    PFTs do not match, don't send anything to the  !
                                   ! new patch.                                        !
                                   !---------------------------------------------------!
                                   same_pft = .false.
                                   area_fac = 0.
                                   !---------------------------------------------------!
                                end if

[mpaiao]

@Viskari thanks for catching it, I think it is a typo in the big-leaf version of ED. I'll double check it tonight, but I think it should be:

fortran
if ( ipft == cpatch%pft(1) ) then
!---------------------------------------------------!
! PFTs match, send all disturbed area to this !
! patch. !
!---------------------------------------------------!
same_pft = .true.
area_fac = act_area_loss(ipa,new_lu)/csite%area(npa)
!---------------------------------------------------!
else
!---------------------------------------------------!
! PFTs do not match, don't send anything to the !
! new patch. !
!---------------------------------------------------!
same_pft = .false.
area_fac = 0.
!---------------------------------------------------!
end if

[Viskari]

Okay, looks sensible, but why is the comparison only done with the first cohort in the patch?

-- Toni

[mdietze]

If this is the "big leaf" variant, there is only one cohort.

[mpaiao]

I just checked the code again, I think the fix above should be enough.
Toni, since you found the bug, could you please submit a pull request? Thanks.

[Viskari]

No problem, just wanted to check it first.

-- Toni

On Mon, May 4, 2015 at 9:25 PM, Marcos Longo [email protected]
wrote:

I just checked the code again, I think the fix above should be enough.
Toni, since you found the bug, could you please submit a pull request?
Thanks.

—
Reply to this email directly or view it on GitHub
#65 (comment).

[apourmok]

Just pulled in the latest from main line and still get this error. @Viskari did you submit a pull request or should I do it?

[Viskari]

The pull request was already submitted a week ago, it just hasn't been
processed yet.

On Tue, May 12, 2015 at 4:30 PM, Afshin Pourmokhtarian <
[email protected]> wrote:

Just pulled in the latest from main line and still get this error.
@Viskari https://github.com/Viskari did you submit a pull request or
should I do it?

—
Reply to this email directly or view it on GitHub
#65 (comment).

[mdietze]

Just did the pull request