GithubHelp home page GithubHelp logo

Comments (9)

egh avatar egh commented on August 20, 2024

Hi Daniel - I'm pretty sure this is the issue that was fixed in #9. I haven't released a new version yet, so you'd need to build from source to get the new version. But I'll release ASAP.

While you are here, would you mind asking a question? @jblachly has fixed ledger-autosync to output ticker symbols instead of CUSIP numbers, so in the future you will see FOO instead of "921943858" as the commodity. I'd like to make this the standard behavior. Will this be a big issue for you, if you have to go back and fix your ledger files?

from ledger-autosync.

jblachly avatar jblachly commented on August 20, 2024

@daniel-vainsencher , @egh is right, commit associated w issue #9 should fix your problem with 0 "..number code.." @ $0 , and a pending commit will also replace the 78468R721 (or whatever) in the "P" lines, which are commodity price lines.

from ledger-autosync.

daniel-vainsencher avatar daniel-vainsencher commented on August 20, 2024

@egh @jblachly Awesome! Yes, I'm currently working of releases, so I can't test right away, we'll see if you get to the release or I move to the dev version first.
To your question, re-exporting is not problem at all for me.

BTW, how about including the dividend indication? separate PR? I could do that if no one else is interested, but I won't get to it very soon.

from ledger-autosync.

egh avatar egh commented on August 20, 2024

@daniel-vainsencher In master, dividends should be supported. Your data should export as something like:

2016/06/20 Transaction
    ; dividend_from: 921943858
    Assets                                     $1.45
    Income:Dividends                          -$1.45

from ledger-autosync.

jblachly avatar jblachly commented on August 20, 2024

@daniel-vainsencher What do you mean by "the dividend indication"? Do you mean formatting correctly as in @egh 's comment -- if so, commit associated with #9 fixes that.

However, if you mean titling the transaction to something like "DIVIDEND RECEIVED", I see no field called <MEMO> in your OFX snippet. The converter looks for this to title the transaction.

You could add a check for this inside the small block of code that checks for type:income , incometype:div and write your own transaction description if none had been provided in an OFX <MEMO> field.

from ledger-autosync.

daniel-vainsencher avatar daniel-vainsencher commented on August 20, 2024

Was talking about getting the right accounts, as per @egh. Time to get
master...

On Oct 28, 2016 6:04 AM, "James S Blachly, MD" [email protected]
wrote:

@daniel-vainsencher https://github.com/daniel-vainsencher What do you
mean by "the dividend indication"? Do you mean formatting correctly as in
@egh https://github.com/egh 's comment -- if so, commit associated with
#9 #9 fixes that.

However, if you mean titling the transaction to something like
"DIVIDEND RECEIVED", I see no field called in your OFX snippet. The
converter looks for this to title the transaction
.

You could add a check for this inside the small block of code that checks
for type:income , incometype:div and write your own transaction
description if none had been provided in an OFX field.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#13 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABcrVlKDJovo52z0-GKOBhlNQUeAVQLLks5q4WX7gaJpZM4Kg2qi
.

from ledger-autosync.

egh avatar egh commented on August 20, 2024

I've just released 0.3.x (had a little trouble getting it to work right :) so you should be able to upgrade using pip.

from ledger-autosync.

egh avatar egh commented on August 20, 2024

@daniel-vainsencher Has this been fixed? Thanks!

from ledger-autosync.

egh avatar egh commented on August 20, 2024

I'm going to close this, please feel free to reopen if it is still an issue.

from ledger-autosync.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.