Doesn't build with fdk-aac 2.0 about pulseaudio-modules-bt

[davidlt]

I think, this is a small bug in CMake file. It does not use LDFLAGS / set library directory for fdk-acc:

  3 libdir=/usr/lib64/fdk-aac                                                       
  4 includedir=/usr/include   
[..]
  9 Libs: -L${libdir} -lfdk-aac                                                     
 10 Libs.private: -lm                                                                                                                                                                                                               
 11 Cflags: -I${includedir}  

[gombosg]

Switching to fdk-aac-free solves the problem, though. Found it dug deep in the repos.

[EHfive]

Is there possible has a ldconfig cache issue?

[gombosg]

It fails in cleanly installed mock environments and on my computer, too.

[davidlt]

https://koji.fedoraproject.org/koji/buildinfo?buildID=1186469

This is installed in standard system location (/usr/lib64), but fdk-aac is not (/usr/lib64/fdk-aac).

You need one line fix in CMake to use directory during linking provided from pkg-config. Then it will work for both.

[gombosg]

See this:

rpmfusion fdk-aac had to be altered to avoid collision with the fedora package, see
https://pkgs.rpmfusion.org/cgit/nonfree/fdk-aac.git/tree/fdk-aac.spec#n36
The non-standard path will cause issues if your package doesn't use pkconfig

I'll use fdk-aac-free from now on but of course if you can fix this later, it's better.

[EHfive]

Hey, I just pushed some changes (f584da9) to branch ld-fix; Could you plz verify it?

[EHfive]

Just to notice that I would bump version to v1.1.99 which contains commits (mostly fixes) after v1.1.

[gombosg]

Confirmed, works fine with fdk-aac 2.0. In Fedora we'll use fdk-aac-free which is still the old version, so it's not urgent to push a new version, but this is useful for the future.

[EHfive]

Confirmed, works fine with fdk-aac 2.0. In Fedora we'll use fdk-aac-free which is still the old version, so it's not urgent to push a new version, but this is useful for the future.

Yep, It's just a version contains fixes for several tiny misses in v1.1