GithubHelp home page GithubHelp logo

Comments (8)

yspreen avatar yspreen commented on June 2, 2024 1

Unfortunately the draft-7 schema itself specifies that the identifier is exactly http://json-schema.org/draft-07/schema#.

Where do you get the # from​? I cannot find a reference for it anywhere

edit: Nevermind, it's in the file that you can download from http://json-schema.org/draft-07/schema

from eu-dcc-schema.

yspreen avatar yspreen commented on June 2, 2024

TL;DR: Schema should be HTTPS, not HTTP.

from eu-dcc-schema.

jschlyter avatar jschlyter commented on June 2, 2024

Unfortunately the draft-7 schema itself specifies that the identifier is exactly http://json-schema.org/draft-07/schema#. A change to 2020-12 is proposed in #13 (and that uses a https URI scheme , let's see if we can have consensus on that.

FWIW, it is perfectly fine for implementors to download the combined schema and update the $schema for their internal use. I would not expect that this schema is available from its own URI and the URI may change before it is final.

Perhaps @dirkx has some comments on what URI will should use for the DGC schema itself?

from eu-dcc-schema.

yspreen avatar yspreen commented on June 2, 2024

Right, sorry for not clarifying!

The current schema is alright. We still use the newest one from the old repo though, and that was 2020-12 with HTTP. I thought it might indicate a more systematic error somewhere, plus I saw an issue vouching to change back to 2020-12 in this repo, so I decided to open the issue. Should've explained better, my bad.

from eu-dcc-schema.

yspreen avatar yspreen commented on June 2, 2024

The release 0.1.0 is invalid for this exact reason, only it's the opposite problem. Using https when it should be http. A new release should be done asap @jschlyter

from eu-dcc-schema.

dirkx avatar dirkx commented on June 2, 2024

Re: "Perhaps @dirkx has some comments on what URI will should use for the DGC schema itself?"

We have some URIs like uvci.eu that we could spend on this. As it may be technically hard to get this on the EU / ECAS website. Will drop @kruzikh an email,

from eu-dcc-schema.

yspreen avatar yspreen commented on June 2, 2024

I also think this discussion isn't really over and the issue shouldn't be closed, since I still want to understand how the inconsistencies arise and how we prevent them in the future.

from eu-dcc-schema.

jschlyter avatar jschlyter commented on June 2, 2024

@yspreen we have now proper schema validation in place as part of the CI testing, so that should handled any obvious errors. I will create a PR to change to a proper 2020-12 that has been validated and @dirkx can get back to us on how to identify the schema itself in a stable way. Such an identifier should include the major version at least.

from eu-dcc-schema.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.