Badge fails for 3-digit numbers about favico.js

[guilhermesimoes]

Hm, that's an infinity symbol (∞). There is only space for 2 characters so the count cannot go over 99.

[adambom]

Yeah, just noticed that in the source code. I get that we can only fit two characters, but putting an Infinity symbol is probably not the best solution. I know I'm going to get bug reports about this.

Is there anything we can do? Even just having 9+, which seems to be commented out in the code, would be a better solution.

[adambom]

Could we reduce font size maybe?

[guilhermesimoes]

Funny that you ask for the 9+ since the count going over 10 was only changed due to popular request. Maybe that should be customizable?

[adambom]

I realized that was silly. Sent a PR that should fix the problem more robustly.

[ejci]

Honestly I never thought that someone will ever need to show badge number bigger than 99 in favicon :)

[ejci]

Thanks for the PR. I will test it and release it with "tiny" modification.

[adambom]

Lol. You should see the number of unread messages in my gmail inbox.

[guilhermesimoes]

Is it a good use case to use an icon badge to display the number of unread email messages though? To me, even a badge count over 9 is pushing it. But that's just my opinion 😆

[ejci]

It will look like this: