GithubHelp home page GithubHelp logo

Comments (17)

branneman avatar branneman commented on June 7, 2024

I have the same problem with v0.3.4

from favico.js.

branneman avatar branneman commented on June 7, 2024

The problem seems to have been introduced with v0.3.3, since it does not work in v0.3.3, but it does work in v0.3.2.

from favico.js.

ejci avatar ejci commented on June 7, 2024

I will release bugfix ASAP

from favico.js.

moacode avatar moacode commented on June 7, 2024

Do you know when a bugfix might be released for this? We're having the same issue.

from favico.js.

ejci avatar ejci commented on June 7, 2024

Bugfix will be released this week.

from favico.js.

ejci avatar ejci commented on June 7, 2024

Fix will be released with version 0.4.0 on 13.04.2014

from favico.js.

wtsui avatar wtsui commented on June 7, 2024

Having the same issue. Any update?

from favico.js.

ejci avatar ejci commented on June 7, 2024

Hi. Im working on new version that will support FontAwesome icons and also server side generated icon for IE11+.
Its lot of work and I recently moved to different country and started new job so I don't have as much time as I would like to have...
Sorry for delay :(

from favico.js.

sgrigson avatar sgrigson commented on June 7, 2024

Version 4.0 seems to have not been released still?

Even a bugfix to the current version would be nice. I was going to use this, but as it turns out it's telling me my favicon.ico is on a different domain (it isn't).

from favico.js.

ejci avatar ejci commented on June 7, 2024

0.3.5 with bugfixes is out. 0.4.0 is still in progress :(

from favico.js.

xob avatar xob commented on June 7, 2024

This might be slightly unrelated, but I tried using this on bitbucket to add a badge to their icon (using a TamperMonkey script), but I get the same error message. This is the error I get: Error initializing favico. Message: Error setting favicon. Favicon image is on different domain (Icon: https://d3oaxc4q5k2d6q.cloudfront.net/m/6a5c573024ea/img/favicon.png, Domain: bitbucket.org)

Is there any plan on adding the different domain feature, or is it simply impossible to do?

from favico.js.

ejci avatar ejci commented on June 7, 2024

The browser will not allow javascript to "manipulate" images that are on different domain. Its for various security reasons.
So unfortunately its impossible to do it directly on the client.

It will be possible with v0.4.0 where Im planning to also introduce server manipulation as a fallback method. It will add badges but without animations (its still work in progress)

from favico.js.

gugiserman avatar gugiserman commented on June 7, 2024

@ejci I'm getting this error right now when running our app over https :(

from favico.js.

ejci avatar ejci commented on June 7, 2024

I removed the check for domain. If the image will have right header it should work from all domains.
https://developer.mozilla.org/en-US/docs/Web/HTTP/Access_control_CORS

from favico.js.

hworld avatar hworld commented on June 7, 2024

It appears that more is needed, even if the server returns correct headers. I sent in a PR at #72. Would be great to see if it works for others. It's working for me now.

from favico.js.

ejci avatar ejci commented on June 7, 2024

@hworld good catch! I will merge the change.

from favico.js.

dtheodor avatar dtheodor commented on June 7, 2024

What about when there is no server support for CORS, which does not allow canvas to be used at all. Can you bypass the canvas?

from favico.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.