GithubHelp home page GithubHelp logo

Comments (3)

pca006132 avatar pca006132 commented on July 20, 2024

Maybe we should add a .clang-format file with

BasedOnStyle: Google

and add a github action to check for formatting on PRs? Error when the source files are not formatted properly.

iirc we cannot enforce pre-commit hook and using GitHub action for formatting commit seems like an overkill and may make the history messy.

from manifold.

elalish avatar elalish commented on July 20, 2024

Sure, that sounds good.

from manifold.

fire avatar fire commented on July 20, 2024

Block the merge until all the pre-commit hooks pass. Add an action to compile. Add an action to test clang format and abort if has changes.

from manifold.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.