GithubHelp home page GithubHelp logo

Comments (5)

hrgdavor avatar hrgdavor commented on July 24, 2024

I would call this user issue, not library issue. :)

from manifold.

pca006132 avatar pca006132 commented on July 24, 2024

I would call this user issue, not library issue. :)

I think it depends on how you view the APIs. For example, the documentation of the warp function explicitly says that it is very easy to create self-intersections and we do not check them now.

The way I see this is that, except certain APIs that we have warned the users, geometrically valid inputs should result in geometrically valid output. Anything violating this is a bug. (which we can also 'fix' by saying that the user should pay attention to blablabla...)
For this case, it is not easy to see what is the minimal number of segments to create a valid result.

from manifold.

elalish avatar elalish commented on July 24, 2024

I look at this exactly like the Warp function, and you're right that it should probably have a similar warning. I am planning to try and implement an overlap removal algorithm, in which case that can be run automatically after operations like these.

from manifold.

pca006132 avatar pca006132 commented on July 24, 2024

@platypii suggested we can rotate the points to avoid getting self-intersections, though it will only work if the points are evenly spaced.

Wonder if this can work in general if we interpolate the points into segments with roughly the same lengths? One problem is that the geometry will be different even for cases that there are no self-intersections.

from manifold.

elalish avatar elalish commented on July 24, 2024

I think that's a little too clever - could easily surprise users. Let's wait for a proper solution that will handle Warp as well.

from manifold.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.