GithubHelp home page GithubHelp logo

Comments (4)

rsaccon avatar rsaccon commented on July 24, 2024 2

I just managed to get my local build working, tested the modified binding, @zalo Split works now as expected, thanks.

from manifold.

zalo avatar zalo commented on July 24, 2024

Ah yeah, nanobind doesn't like that it returns an std::pair...

It would have to be replaced with something like:

      .def("split", [](Manifold &self, Manifold& cutter) {
            auto p = self.Split(cutter);
            return nb::make_tuple(p.first, p.second);
           },
           nb::arg("cutter"),
           "Split cuts this manifold in two using the cutter manifold. The "
           "first result is the intersection, second is the difference. This "
           "is more efficient than doing them separately."
           "\n\n"
           ":param cutter: This is the manifold to cut by.")

Having trouble getting Manifold built on my machine or I'd test this and make a PR...

from manifold.

rsaccon avatar rsaccon commented on July 24, 2024

I also tried to build locally on my old intel mac, finally was able to build, but my attempt to use the local built bindings (the not yet modified ones) failed, so many things can go wrong, well, I guess I have to wait for the next pipy release for this Split() binding to work ...

from manifold.

zalo avatar zalo commented on July 24, 2024

If a version of this PR #593 works, you might be able to extract a working version of the Python wheel from the Github Actions build.

from manifold.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.