GithubHelp home page GithubHelp logo

Comments (2)

LucGranato avatar LucGranato commented on August 20, 2024

This gave me a brain aneurysm.
Lucky that APM was the only thing that was different between the local test and the production environment. It was easier to guess...
Going back to version 2.5.1 fixed the problem.

from apm-nodejs-http-client.

blakeembrey avatar blakeembrey commented on August 20, 2024

@watson Is there any context here for fixing this? I've gone through and fixed it up on my side, but I can't open a working PR because breadth-filter means either making a trade-off of cloning context on a new object and failing the circular reference tests, or stringifying within the breadth-filter callback but it automatically traverses the headers object test case and fails because we don't stringify that. Are either of these trade-offs acceptable? Alternatively, I can update breadth-filter to always call fn on every value (even object and array), which would solve for both these issues.

Edit: Also, alternatively, could just add validation onto context.{request,response}.headers instead to ensure they're the shape expected. Why would anyone use this with unexpected input?

from apm-nodejs-http-client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.