helm test fails when security is enabled about helm-charts

[jordansissel]

Thinking about how to solve this, I'm not exactly sure, but maybe we can reuse the secrets/settings given to elasticsearch nodes? That is, if security is enabled, use the ELASTIC_USERNAME and ELASTIC_PASSWORD for auth, and the elastic-certificates-pem for SSL?

[Crazybus]

Thinking about how to solve this, I'm not exactly sure, but maybe we can reuse the secrets/settings given to elasticsearch nodes? That is, if security is enabled, use the ELASTIC_USERNAME and ELASTIC_PASSWORD for auth, and the elastic-certificates-pem for SSL?

Yup! The helm test manifest is defined in test/test-elasticsearch-health.yaml. What would need to be done is to add in all of the extraEnvs and secretMounts logic into the test container so that any secrets/environment variables/certificates are also available in the test container for the curl check to work.

However the more important issue is that the current helm test doesn't do anything more than the current readinessProbe is doing. Ideally I would rather add some serverspec like tests with goss (think serverspec but written in go and uses yaml to configure the tests). So instead of spawning a new separate pod we would be running tests against the actual running container itself. This would also make it a lot easier to have separate tests for each example configuration too and means we can test important container level things like vm.max_map_count being set properly.

[jordansissel]

@Crazybus +1 everything you said. I'm content to close this as a known-issue that is intended to be fixed in the context of your comment.