GithubHelp home page GithubHelp logo

Comments (4)

icehaunter avatar icehaunter commented on May 10, 2024 1

@davidmartos96 thanks for the note! I'll investigate and get back to you

from electric.

davidmartos96 avatar davidmartos96 commented on May 10, 2024

I've just bisected the latest commits and it is in fact a regression from 232f7a5

from electric.

davidmartos96 avatar davidmartos96 commented on May 10, 2024

Would this be a correct test for this behavior? (process.test.ts)

It passes on commits before 232f7a5 and fails on later commits.
I'm just not sure if those would be the correct expectations.

test('DELETE after DELETE sends clearTags', async (t) => {
  const { adapter, runMigrations, satellite, authState } = t.context
  await runMigrations()

  await satellite._setAuthState(authState)
  
  await adapter.run({
    sql: `INSERT INTO parent(id, value) VALUES (1,'val1')`,
  })
  await adapter.run({
    sql: `INSERT INTO parent(id, value) VALUES (2,'val2')`,
  })

  await adapter.run({ sql: `DELETE FROM parent WHERE id=1` })

  await satellite._performSnapshot()

  await adapter.run({ sql: `DELETE FROM parent WHERE id=2` })
  
  await satellite._performSnapshot()

  const entries = await satellite._getEntries()

  t.is(entries.length, 4)
  
  const delete1 = entries[2]
  const delete2 = entries[3]

  t.is(delete1.primaryKey, '{"id":1}')
  t.is(delete1.optype, 'DELETE')
  // No tags for first delete
  t.is(delete1.clearTags, '[]')

  t.is(delete2.primaryKey, '{"id":2}')
  t.is(delete2.optype, 'DELETE')
  // The second should have clearTags
  t.not(delete2.clearTags, '[]')
})

from electric.

icehaunter avatar icehaunter commented on May 10, 2024

VAX-910 internal

from electric.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.