Infer from package.json about electron-packager

[sbruchmann]

There’s also productName, which is a bit more suitable for this task.

[sindresorhus]

Yes, indeed.

[klaemo]

app-version could be inferred from the package.json version field as well, I think. That way building a correctly version app would be as simple as npm version patch|minor|major && npm run build (assuming npm run build does the right thing).

[rahatarmanahmed]

+1, I might take a stab at this. Should it check for package.json in the cwd? Or search upwards?

Also most likely electron-packager will be in devDependencies, but should it also try and fallback to dependencies if it can't find that?

[kfranqueiro]

I think searching upwards seems like a good plan regardless, but here are a couple of off-the-cuff ideas in terms of where to start searching:

• Start with opts.dir and look upwards, since there may be a package.json there (e.g. to specify main)
  • Possible disadvantage: if you have a more fully-populated package.json higher up your tree
• Start from ../.. relative to __dirname of electron-packager's main modules (i.e. above the node_modules folder containing it) - this would likely coincide with process.cwd() in common cases, but wouldn't break if people ran it from elsewhere
  • Possible disadvantage: if you use electron-packager globally-installed?

My brain cells are limited at the moment so feel free to point out if I am overlooking something dumb :)

[rahatarmanahmed]

A good way to avoid the problem in the first way is to keep looking in higher in the tree if the first package.json you find doesn't have an electron-prebuilt dependency or name.

[Mingling94]

Request: This should infer to package the dependencies but not the devDependencies

[rahatarmanahmed]

Do you mean to include dependencies in the build or to use the electron-prebuilt version in dependencies?

[Mingling94]

^The former, not your pr.

dependencies mean the electron app needs the package to run, right? devDependencies are not needed. If one uses the package.json as per npm philosophy, ALL the dependencies should be in node_modules and included in the packaged product.

gets off soapbox

[rahatarmanahmed]

We already have --prune, so if node_modules is in your src path, you can use that to ignore devDependencies.

[Mingling94]

Ah, I see!