Comments (8)
Either Linux is the odd one out or Windows is. OS X is a special exception because of how Mac apps work. I'd argue that Windows is being weird - why does it need to be in a subfolder of the args.out
folder?
from electron-packager.
I think it's Linux, because if I don't specify a --out
the content ends up in ./App-linux/
.
from electron-packager.
It makes sense to default to ./App-linux
, so that it doesn't pollute the current directory. If args.out
is always appended by /$APP_NAME-linux
, that will make #33 more complex (i.e., having to rename that folder before packaging it up).
from electron-packager.
In conjunction with #40, I think the output folder should default to a combination of ./$APP_NAME-$PLATFORM-$ARCH
from electron-packager.
I would prefer: ./out-folder/$PLATFORM/$ARCH/foo.app
or ./out-folder/$PLATFORM-$ARCH/foo.app
especially when running with --all
from electron-packager.
+1 Just hit this today, I like using platform/arch in the output folder. I agree with @jenslind I think ./out-folder/$PLATFORM/$ARCH/...
is best, and ./out-folder/$PLATFORM-$ARCH/...
is good.
from electron-packager.
Regarding which one is the odd one out, I'd also say it's Linux, for a couple of reasons:
- It doesn't use
os.tmpdir()
to do its work first like Win/Mac - Whereas the Win/Mac scripts effectively do
path.join(opts.out || process.cwd(), ...)
, the Linux script doesopts.out || path.join(process.cwd(), ...)
from electron-packager.
I fixed the Linux inconsistency today in 86edff6, but leaving this open as there are some other good suggestions we can think about in the future
from electron-packager.
Related Issues (20)
- Allowing setting the display name to a different value from the app name HOT 1
- exe/asar archive created with jwt-decode(3.1.2) does not work HOT 1
- Packager outputs to console error on successful build. HOT 2
- Using sqlite3, it appears that the sqlite3 module is not found after compilation. HOT 4
- Package an Electron app on an Apple Silicon chip for Windows with Electron Packager HOT 1
- electron-packager does not recognize 64-bit wine installations that do not include the wine64 command HOT 2
- Preserve file attributes while copying with 'extra-resource' option HOT 2
- `--arch=all` broken on macOS
- parallel download race condition errors out with: dest already exists HOT 2
- --win32metadata.requested-execution-level=requireAdministrator Can't create shortcut desktop app when install app after build. HOT 1
- Error: spawn /usr/bin/node ENOENT when launching a process with child_process.spawn from app packaged with electron-packager HOT 6
- risc-v is not supported HOT 2
- Mac OS Arm64 is corrupted when built on Linux 64
- The link to API documentation is broken HOT 3
- Electron Packager 18.1.2 breaks electron-forge HOT 2
- EPERM: operation not permitted, rmdir <path> HOT 1
- Unable to read preload script cdv-electron-preload.js HOT 2
- App crashes on MAS after uploading correctly app
- error when packageConfig.tmpdir set to false HOT 4
- Provide an option to preserve the state of the node_modules when packaging HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from electron-packager.