GithubHelp home page GithubHelp logo

Comments (8)

malept avatar malept commented on May 26, 2024

Either Linux is the odd one out or Windows is. OS X is a special exception because of how Mac apps work. I'd argue that Windows is being weird - why does it need to be in a subfolder of the args.out folder?

from electron-packager.

sindresorhus avatar sindresorhus commented on May 26, 2024

I think it's Linux, because if I don't specify a --out the content ends up in ./App-linux/.

from electron-packager.

malept avatar malept commented on May 26, 2024

It makes sense to default to ./App-linux, so that it doesn't pollute the current directory. If args.out is always appended by /$APP_NAME-linux, that will make #33 more complex (i.e., having to rename that folder before packaging it up).

from electron-packager.

junosuarez avatar junosuarez commented on May 26, 2024

In conjunction with #40, I think the output folder should default to a combination of ./$APP_NAME-$PLATFORM-$ARCH

from electron-packager.

jenslind avatar jenslind commented on May 26, 2024

I would prefer: ./out-folder/$PLATFORM/$ARCH/foo.app or ./out-folder/$PLATFORM-$ARCH/foo.app especially when running with --all

from electron-packager.

englercj avatar englercj commented on May 26, 2024

+1 Just hit this today, I like using platform/arch in the output folder. I agree with @jenslind I think ./out-folder/$PLATFORM/$ARCH/... is best, and ./out-folder/$PLATFORM-$ARCH/... is good.

from electron-packager.

kfranqueiro avatar kfranqueiro commented on May 26, 2024

Regarding which one is the odd one out, I'd also say it's Linux, for a couple of reasons:

  • It doesn't use os.tmpdir() to do its work first like Win/Mac
  • Whereas the Win/Mac scripts effectively do path.join(opts.out || process.cwd(), ...), the Linux script does opts.out || path.join(process.cwd(), ...)

from electron-packager.

max-mapper avatar max-mapper commented on May 26, 2024

I fixed the Linux inconsistency today in 86edff6, but leaving this open as there are some other good suggestions we can think about in the future

from electron-packager.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.