default ignores and --ignore not working (windows) about electron-packager

[jenslind]

Hmm, I can't reproduce this issue on Mac. Does your linux and mac builds work as expected?

[zaggino]

Can you please try the repo above? https://github.com/zaggino/brackets-electron
npm run bundle-mac doesn't even copy the app files into the Contents/Resources/app folder for some reason (it does copy on Windows but ignores excludes)

[zaggino]

Nevermind, found one issue, going to submit a PR

[zaggino]

PR for Mac is up, I'll check what's wrong on Windows too

[zaggino]

PR for Windows is up too.

[zaggino]

@maxogden another issue with 4.1.1:
I have this in my shell script:

electron-packager . Bracketron --platform=$1 --arch=$2 --version=$3 --ignore='/node_modules/electron-rebuild($|/)'

but minimist will convert this to:

C:/Program Files (x86)/Git/node_modules/electron-rebuild($|/)

I've put console.log here: https://github.com/maxogden/electron-packager/blob/master/cli.js#L4

[zaggino]

Actually this is done even before it reaches minimist for some reason, sorry. I need to check why.

[zaggino]

Ok, I actually need to do

--ignore='./node_modules/electron-rebuild$'

to make it work without resolving the first / to C:/Program Files (x86)/Git/

But it excludes correctly now. You can close this or make some notes based on my findings into the README if you wish. Thanks for merging the PRs.

[zaggino]

Ah, I'm spamming here but still not good. I need to exlude a folder tools from my app but I don't want to exclude a folder something/tools too. Excludes should only be matched against the root of the app.