GithubHelp home page GithubHelp logo

Comments (3)

malept avatar malept commented on May 23, 2024

I would think that if anything, this needs to be set to true when the host platform (i.e. os.platform()) is win32, not the target platform.

Perhaps. It was originally only added to win32.js (via #46), so when I refactored, I didn't want to change that behavior.

from electron-packager.

kfranqueiro avatar kfranqueiro commented on May 23, 2024

I've been manually testing everything I can think of and ignore is one of the last things left on my list, so hopefully I'll hit that sometime in the coming week to confirm this.

from electron-packager.

kfranqueiro avatar kfranqueiro commented on May 23, 2024

I've confirmed tonight that this is indeed wrong - for example, --ignore='ignore/this' will ignore correctly for windows builds on windows, but not linux/mac builds on windows. The check should be detecting against the host platform, not the platform being targeted. (Or perhaps look at path.sep and if it's not already /, replace based on it.)

I should be able to come up with a PR for this.

from electron-packager.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.