How does '--asar=true' works? about electron-packager

[max-mapper]

thanks for the bug report! heres the line of code we're calling in the implementation for reference https://github.com/maxogden/electron-packager/blob/554f3b735483319450c2ad8d0e0cba90e041ebe2/common.js#L10, it's pretty weird the asar file that you get is empty.

I or another maintainer will try and reproduce when we get a chance

[kfranqueiro]

This sounds like a similar problem to what #73 is trying to solve. Apparently it's an issue on more than a single platform. It certainly looks as if mac.js is already adding Resources to the path, and then asarApp is adding resources again, which is wrong.

[masom]

@kfranqueiro yep. On windows the app is packaged at /path/to/app/resources but electron-packager adds another resources path component. This probably happened by porting the os x code to windows. The OS X app generates the resources folder under the MyApp.app/Resources which does not exists on windows.

[masom]

Seems like problems got introduced in 8134009

[masom]

8134009#diff-a16e9b0497c5d6579f17c2c139cb3abaL140 was modified to append resources but some file operations did not take this into considerations.

[malept]

Yeah, sorry about that. Give me a second to revert the behavior.

[masom]

@malept #73 should fix it.

[malept]

@masom #73 is not quite right in the Mac code, it adds an extra folder.

@enkows please test 178b3d4 with a Mac build, it reverted the behavior to what it was before my refactoring.

[masom]

@malept 178b3d4 works for us on both windows and OS X

[kfranqueiro]

The Mac code should be fine now, as it already adds Resources on its side of the code.

Edit: ah, sorry, now I see what you were referring to in the original PR.

[enkows]

@malept @masom
178b3d4 fixed the path issue, but the app.asar still has a problem.

$ cp electron/Electron.app/Contents/Resources/app.asar app.asar
$ asar list app.asar
/app.asar

$ asar extract app.asar app/app.asar
$ asar list app/app.asar
/package.json
/index.html
/main.js

It seems like the .asar file packaged twice.

UPDATE:
It's works fine now!
I wrote some scripts to solve the path problem before. After I remove those scripts, it works fine.

Thanks!