modules from repositories are ignored when building about forge

[MarshallOfSound]

Hmm, @G3z can you post your package.json structure

[G3z]

Sure!

{
  "name": "revenue-gui",
  "version": "1.0.0",
  "productName": "Revenue",
  "description": "",
  "main": "server/main.js",
  "scripts": {
    "start": "electron-forge start",
    "package": "electron-forge package",
    "make": "electron-forge make"
  },
  "author": "",
  "license": "ISC",
  "dependencies": {
    "debug": "^2.6.0",
    "electron-compile": "^5.1.2",
    "flux": "^3.1.2",
    "lodash": "^4.17.4",
    "numeral": "^2.0.4",
    "react": "^15.4.2",
    "react-d3": "^0.4.0",
    "react-dom": "^15.4.2",
    "react-photonkit": "https://github.com/react-photonkit/react-photonkit#master",
    "react-router": "^3.0.2",
    "recharts": "^0.20.5",
    "revenue-core": "^1.0.4"
  },
  "devDependencies": {
    "babel-preset-latest": "^6.16.0",
    "babel-preset-react": "^6.5.0",
    "del": "^2.2.2",
    "electron-prebuilt-compile": "1.4.14",
    "merge2": "^1.0.3",
    "optimist": "^0.6.1",
    "vinyl-buffer": "^1.0.0",
    "vinyl-source-stream": "^1.1.0"
  },
  "config": {
    "forge": {
      "make_targets": {
        "win32": [
          "squirrel"
        ],
        "darwin": [
          "zip"
        ],
        "linux": [
          "deb",
          "rpm"
        ]
      },
      "electronPackagerConfig": {},
      "electronWinstallerConfig": {
        "name": ""
      },
      "electronInstallerDebian": {},
      "electronInstallerRedhat": {},
      "github_repository": {
        "owner": ""
      },
      "windowsStoreConfig": {
        "packageName": ""
      }
    }
  }
}

[malept]

That is quite odd. Does react-photonkit get deleted if you run npm prune --production in your app directory?

[G3z]

yes npm prune --production removes react-photonkit

[MarshallOfSound]

@G3z What is your npm version?

[G3z]

4.1.1 is this an npm bug ?

[MarshallOfSound]

From the sounds of it yes, npm prune --production shouldn't remove a production dependency. Can you revert to node v6 and npm v3 and see if it fixes the "issue" 😄

[G3z]

I reverted to [email protected] removed node_modules and npm installed.
now electron-forge make produced a working build!
so it's an npm bug (or changed behavior)
TY

[malept]

Do you mind filing a bug in in the npm repo and linking it here?

[G3z]

I'm digging the changelogs to be sure it's a bug, than I will update you.

[malept]

This seems to be it: npm/npm#9889