GithubHelp home page GithubHelp logo

Comments (6)

cassidyjames avatar cassidyjames commented on July 4, 2024 2

I agree with the above. If we wanted to add muted variants to all hardware types we could but I think the original problem has been resolved.

from wingpanel-indicator-sound.

D0J0P avatar D0J0P commented on July 4, 2024 1

You're right, radio buttons have never had an inactive state, so it would be confusing to bring that in, making it look disabled.

I think #226 is a good solution. Part of the confusion was probably that all outputs were using audio-volume-high, making them all look like they're on full volume, and they weren't adjustable.

from wingpanel-indicator-sound.

danirabbit avatar danirabbit commented on July 4, 2024

That's a clever idea and seems like a nice little detail :)

from wingpanel-indicator-sound.

cassidyjames avatar cassidyjames commented on July 4, 2024

Oops, re-opening in case we want to address it, but I'm not sure it's an issue with the updated design.

from wingpanel-indicator-sound.

D0J0P avatar D0J0P commented on July 4, 2024

Are there a lot of pulse icons? If not, would it be possible to make muted variants of them? They would be greyed out and slashed, as if they're turned off or not in use, making it easy to see what's used, and looks less busy.

from wingpanel-indicator-sound.

danirabbit avatar danirabbit commented on July 4, 2024

These are device type icons, not anything specific to pulse. So it could be any device. Right now we have:

  • audio-card
  • audio-headphones
  • audio-headset
  • audio-input-microphone
  • audio-speakers
  • audio-subwoofer
  • camera-photo
  • camera-web
  • computer
  • computer-convertible
  • computer-laptop
  • phone
  • video-display-tv

There might be others, but this is what seems reasonable for devices. I'm not sure it's super worth adding -muted variants for every device since we already indicate the active device with a checkmark and device icons aren't conflated with status icons here anymore.

Something I would be worried about would be making a non-active device appear disabled or unavailable

from wingpanel-indicator-sound.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.