parsing "const char* const*" generates "const char ** const" about pycparser

[eliben]

Thanks for the report. Can you provide a full test case using the pycparser API? I assume you're using the C code generator as well?

[schachmat]

Here you go:

bla.c: int test(const char* const* arg);

test.py:

#!/bin/env python

import sys
from pycparser import parse_file, c_generator, c_ast

sys.path.extend(['.', '..'])

class FuncDeclVisitor(c_ast.NodeVisitor):
    def visit_FuncDecl(self, node):
        decl = c_ast.Decl("hui", None, None, None, node, None, None)
        print(c_generator.CGenerator().visit(decl))

ast = parse_file("bla.c", use_cpp=True, cpp_args=[r'-Ifake', r'-I.'])
FuncDeclVisitor().visit(ast)

output when running test.py is: int test(const char ** const arg)
expected output is: int test(const char * const * arg)

[eliben]

Hmm, curiously pycparser's cdecl also gets this wrong:

$python examples/cdecl.py "const char* const* arg;"
Explaining the declaration: const char* const* arg;

arg is a const pointer to pointer to const char

And:

$ python examples/cdecl.py "const char** const arg;"
Explaining the declaration: const char** const arg;

arg is a pointer to const pointer to const char

Those should be reversed (the first explanation suits the second decl, and vice versa).

The problem may even begin at AST parsing:

    const char ** const arg;
    const char * const * arg2;

FileAST: 
  Decl <ext[0]>: name=arg, quals=['const'], storage=[], funcspec=[]
    PtrDecl <type>: quals=[]
      PtrDecl <type>: quals=['const']
        TypeDecl <type>: declname=arg, quals=['const']
          IdentifierType <type>: names=['char']
  Decl <ext[1]>: name=arg2, quals=['const'], storage=[], funcspec=[]
    PtrDecl <type>: quals=['const']
      PtrDecl <type>: quals=[]
        TypeDecl <type>: declname=arg2, quals=['const']
          IdentifierType <type>: names=['char']