DataFrame cast string to Time about explorer

[philss]

Hi @hoetmaaiers 👋

I believe you can't change the type of the series in the transformation.
Since you are trying to execute Elixir code for this, how about using Enum.map/2 for the transformation?

Something like this:

alias Explorer.{DataFrame, Series}

df = DataFrame.from_map(%{a: ["00:30:00", "01:00:00", "05:30:00"]})

transform_duration = fn duration ->
  time = Time.from_iso8601!(duration)
  time.hour + (time.minute / 60) + (time.second / 60*60)
end

new_a_series = df["a"] |> Series.to_list() |> Enum.map(transform_duration) |> Series.from_list()

DataFrame.mutate(df, a: new_a_series)

WDYT?

PS: you don't need that |> Series.from_list() part for this to work.

[cigrainger]

This is a bug! We shouldn't assume you're not changing dtypes when using Series.transform/2. I'll fix it. 👍

[cigrainger]

@hoetmaaiers the solution suggested by @philss is basically what Explorer is doing under the hood anyway. The fix I pushed today means your original code will work now -- it was a bug I introduced when implementing Series.transform/2. I accidentally had it so there was an assumption that transform would retain the original dtype and that's not every useful 😀. So now we check the dtype of the new list before creating a series from it.

[hoetmaaiers]

Thank you @philss , thinking outside Explorer with regular Elixir, why didn't I think of this myself...

@cigrainger, does this mean @philss isn't the only way of doing this?

[hoetmaaiers]

The combination of DataFrame.mutate and Series.transform isn't working for me. Probably it is my bad, but the documentation seems to miss this combination. What am I doing wrong?

df = DataFrame.from_map(%{a: ["00:30:00", "01:00:00", "05:30:00"]})

transform_duration = fn duration ->
  time = Time.from_iso8601!(duration)
  time.hour + (time.minute / 60) + (time.second / 60*60)
end

DataFrame.mutate(df, a: &Series.transform(&transform_duration.(&1["a"])))

Returns me this compile error: ** (CompileError) dataframe.exs:36: nested captures via & are not allowed: &transform_duration.(&1["a"])

[josevalim]

You are not allowed to use & inside &, that’s what the compile error is telling you. Could the error message have been clearer in this case?

[hoetmaaiers]

No the error message is clear, no doubt. I'm struggling with the proper combination of transform and mutate and tried several approaches.

Maybe the documentation for this use case can be clearer? I based myself on the notebook example in this repo.