Refactor suggestions engine about elixir_sense

[lukaszsamson]

Well, I don't really know about other currently maintained users of elixir_sense, I'm only certain that elisir-ls does not use it. When I introduced the Hint module I was mainly concerned with not introducing breaking changes but maybe we should. It's a relict from iex REPL and it's not that useful for code editors. In particular the LSP protocol does not define any hints and clients are free to build them from completion items. Removing it would make Complete module simpler and more compatible with other providers. If we decide to keep it, it would be easy to generate it as a last step as the algorithm is rather simple - it just takes the longest common prefix.

[msaraiva]

Awesome! I agree. I think there's no practical use for it when working with editors.

Let's just remove the damn thing!

@axelson in case you know any maintainers that might still need this feature, please ping them so they can have a last opportunity to change our mind :)

[axelson]

I don't know of any so I think you should go ahead 👍