GithubHelp home page GithubHelp logo

Comments (4)

Cam avatar Cam commented on July 19, 2024

Interesting idea! A fallback would be more difficult.

from shopify-theme-framework.

georgebutter avatar georgebutter commented on July 19, 2024

A fallback would be more difficult

In what way?

from shopify-theme-framework.

Cam avatar Cam commented on July 19, 2024

If it falls back to an input field, the users can still add quantities without requiring JS. Maybe that doesn't matter though, what were you thinking the replacement would be?

from shopify-theme-framework.

georgebutter avatar georgebutter commented on July 19, 2024

Good point, I mostly don't like it being a number field. User agent styling on some browsers has not been reset and you get the up and down buttons. But it also shouldn't really be a text field/editable.
Could use noscript as a fallback but that is ugly...

I don't want Cartfox to have to rely on an input field value either, on ajax templates it doesn't make much sense to be able to edit the number.

from shopify-theme-framework.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.