GithubHelp home page GithubHelp logo

Comments (5)

derhuerst avatar derhuerst commented on July 18, 2024 1

The debug module might also work.

from signal-protocol.

elsehow avatar elsehow commented on July 18, 2024

@derhuerst That could be good!

I am not sure yet which of these messages the caller might care about or want to work with programmatically, and which of these messages are, "everything is working fine, FYI!"

from signal-protocol.

derhuerst avatar derhuerst commented on July 18, 2024

Theoretically, all the messages that a caller is interested in should be available via returns values, events, or something similar. Console logging a very unintuitive and also inflexible way of getting messages, but certainly necessary in debugging. That's why I propose debug for internal messages that only contain messages related to the inner workings of the module and events/return values/exceptions for all messages interesting to "outsiders".

from signal-protocol.

elsehow avatar elsehow commented on July 18, 2024

Sounds good to me. If someone ends up needing a value or event, we can always pass it up as an event later.

As an initial step, I may just go through and comment out all of the console.log statements. The comments can serve as a guide for helpful things to debug.

from signal-protocol.

elsehow avatar elsehow commented on July 18, 2024

I commented out all the console.logs in 79f7037 and published v0.0.6

I think I will close this issue for now. If callers end up needing these messages, we can use debug or whatever else makes sense for their usecase 👍

from signal-protocol.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.