[Cleanup] - specify destruction tasks for the New function about fusion

[blake-mealey]

I just ran into this and came to make sure there was an issue for it. This is what I am doing for now to get around this:

function MyComponent(props)
  ...
  local maid = Maid.new()
  local function startPolling()
    maid:GiveTask(UserInputService.InputBegan:Connect(...))
  end

  local frame; frame = New 'Frame' {
    ...,
    [OnEvent 'AncestryChanged'] = function(instance, parent)
      if frame == instance then
        maid:DoCleaning()
        if parent then
          startPolling()
        end
      end
    end
  }

  return frame
end

Which is obviously a bit more bulky than is desirable.

I think the proposed [Cleanup] = {} is a good solution ✅

[Gargafield]

I think Fusion should have an in-house Janitor, eliminating the need for any outside libraries.

[dphfox]

I think Fusion should have an in-house Janitor, eliminating the need for any outside libraries.

The [Cleanup] feature should cover all the use cases typically needed by Fusion developers, since the vast majority of other objects garbage collect nicely. In addition, it makes sense to tie cleanup behaviour to instances, given that Fusion's UI system is built entirely around them.

[Gargafield]

I think Fusion should have an in-house Janitor, eliminating the need for any outside libraries.

The [Cleanup] feature should cover all the use cases typically needed by Fusion developers, since the vast majority of other objects garbage collect nicely. In addition, it makes sense to tie cleanup behaviour to instances, given that Fusion's UI system is built entirely around them.

Could be really nice to clean up springs or states forcefully, instead of waiting for the gc to do its job.

[dphfox]

I think Fusion should have an in-house Janitor, eliminating the need for any outside libraries.

The [Cleanup] feature should cover all the use cases typically needed by Fusion developers, since the vast majority of other objects garbage collect nicely. In addition, it makes sense to tie cleanup behaviour to instances, given that Fusion's UI system is built entirely around them.

Could be really nice to clean up springs or states forcefully, instead of waiting for the gc to do its job.

Thing is, because they're entirely garbage-collectable, there's nothing that needs to be cleaned up manually.

[dphfox]

Update to this: it seems Roblox themselves are adding a .Destroyed event to Instances, which might make this feature mostly obsolete, except maybe for some keystroke savings. With this in mind, I'm going to be reconsidering whether this feature should be added as part of the core of Fusion anymore, or if it would be better to polyfill the event until it's made more widely available.

I'll see if I can poke at the behaviour of this event a bit more in the meantime.

[dphfox]

Update on this - it turns out Destroyed only runs when you invoke :Destroy() on an instance, making it practically useless for Fusion code :(

I'm going to have to advise people away from using the shiny new thing, which sucks hard. Either that, or fix Destroyed manually inside the New function.