Put more thought into the context menus about pipeline-editor

[ptitzler]

I have pretty much only used these features (in order of frequency) during the past six months:

• open node properties
• open file
• copy and paste a node (to retain defined properties, which are a pain to re-enter).

[bourdakos1]

@marthacryan do you have any thoughts on this?

[marthacryan]

@elyra-ai/core-committers If anyone else wants to give their opinion go ahead!

[marthacryan]

Small issues:

• There is a mix of casing style One two three vs One Two Three
• There seems to be no logic of when an item is completely hidden vs disabled
• There doesn't seem to be a lot of logic behind the dividers, some things are grouped that don't make sense (highlight, open file, properties) where most of the time there is a divider between everything.

+1 on these

• Context menus don't disappear on blur

I'm not able to reproduce this?

Questions:

• Is the highlight menu useful? I didn't realize what it did until today. I always thought it had something to do with git so I just ignored it. Additionally, I would assume highlighting something would act as selection, but highlighting a branch and then deleting only deletes the selected node, not the highlight. I motion to delete this menu in vscode release to see if it's something people actually want, because to me, it just adds confusion.

+1 I don't think the highlight menu does much

• Do we need the three dot button on the nodes? It seems to do the exact same thing as right click? Is there an accessibility reason? If so why don't we have the same on links, comments, etc...

This is a canvas thing so I'm not sure, but it doesn't really strike me as important either way. Maybe we should reach out to the canvas people to make sure it isn't an accessibility issue or anything. I don't know if this is configurable though so if people do think we should get rid of it then we'll have to look into how it can be removed / request that configuration on the canvas side.

Suggestions:

• Remove Undo, Redo, Select All. These types of actions normally live in an edit menu or toolbar
• Remove the overflow for Edit, this should just be a group of Cut, Copy, Paste
• Remove most of the dividers, the only divider should probably be the edit group. I think a good rule of thumb should be if you can't think of a generic name for the group it shouldn't have a divider (in most cases there shouldn't be groups of one item, because then the divider just creates noise, but there can be exceptions to this rule)

+1 on these

Jupyter vs VSCode

Jupyter:

• uses their own context menu ui
• uses icons to the left for a lot of menu items
• has keyboard shortcut to the right
• never uses dividers
• rarely uses an overflow menu

VSCode:

• uses system context menu, but doesn't expose the API to custom web editor views
• uses dividers sparingly
• rarely uses an overflow menu

I'm a little confused why these are different? Canvas has a built-in context menu, are you trying to move over to using the context menus of JL / VSCode?

[bourdakos1]

Context menus don't disappear on blur

Oh I think it might be a vscode issue maybe? If I click on vscode ui the context menu hangs around. Also if I right click on common properties it sticks around, but that's not a super huge issue.

This is a canvas thing so I'm not sure, but it doesn't really strike me as important either way. Maybe we should reach out to the canvas people to make sure it isn't an accessibility issue or anything. I don't know if this is configurable though so if people do think we should get rid of it then we'll have to look into how it can be removed / request that configuration on the canvas side.

I have the dots hidden on the Chrome extension. This also isn't a huge issue, I don't think it's hurting anything being there, just feels strange that you can right click on everything, but only the non-comment nodes have an indicator.

I'm a little confused why these are different? Canvas has a built-in context menu, are you trying to move over to using the context menus of JL / VSCode?

We need to use the built-in canvas context menu (at least for vscode, because they don't provide an API for the native context menus in a custom editor). This is more a styling thing, should we try to match them to the style of vscode/jupyter? Jupyter shouldn't be hard, but vscode gets complicated because it uses native context menu, so we would need themes for windows/mac/etc...

[bourdakos1]

[WIP] new menus (let me know if I'm missing anything)

background:

New Comment
-----------------
Paste

Node:

Open File
Open Properties
-----------------
Create Supernode
-----------------
Cut
Copy
-----------------
Disconnect
Delete

Link:

Delete

Comment:

Note: It seems like creating a supernode doesn't work if only a comment is selected. We should disable it in this scenario, if that is the case and this is not a bug.

Create Supernode
-----------------
Cut
Copy
-----------------
Disconnect
Delete

Expanded Supernode:

Collapse Supernode
-----------------
Create Supernode
-----------------
Cut
Copy
-----------------
Disconnect
Delete

Collapsed Supernode:

Expand Supernode
-----------------
Create Supernode
-----------------
Cut
Copy
-----------------
Disconnect
Delete