GithubHelp home page GithubHelp logo

Comments (4)

sillykelvin avatar sillykelvin commented on July 22, 2024

Thanks for your attention. As I mentioned in issue [#29], please consider variable name change when you are making themes. The variables are extracted from org-page.el, into op-vars.el on branch devel.

from org-page.

ic3guy avatar ic3guy commented on July 22, 2024

I think this would be a good place to ask a quick question. Why is there a (defcustom template-directory ...) but no (defcustom theme-directory ...). Was it just a design decision to force themes to be install in "org-page-base/themes/...".

The change might be to replace calls to (op/get-theme-dir) to just get the theme-dir directory defined as a variable. Does this make sense?

from org-page.

sillykelvin avatar sillykelvin commented on July 22, 2024

Good question, I did not realize this inconsistency until you pointed out. I will evaluate the possibility of changing op/get-theme-dir into variable, and it may be implemented later.

from org-page.

sillykelvin avatar sillykelvin commented on July 22, 2024

Implemented, closing.

from org-page.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.