Comments (1)
Availability is there a reason why Uart::Config no have fifo: bool field?
The reasoning was, there's very little reason to not want a FIFO. Having a FIFO is just better: it makes things faster, less likely to lose bytes if you have irq delays, etc. You might think if you don't enable the FIFO you don't have to worry about flushing etc, but that's not true. You still have a 1 word "FIFO" which is the DR itself, so you can still have problems if you don't flush correctly.
Possible blocking_flush should use TXFIFO Empty flag if FIFO is enabled.
If flush()
is returning before the fifo is empty with the current code then yes, definitely.
Why async flush() use blocking_flush? I think we should wait Transmission complete interrupt or TXFIFO empty interrupt
No one has implemented async flush yet, so it uses blocking flush for now, since it at least works even if not optimally. A PR fixing this would be welcome.
from embassy.
Related Issues (20)
- [embassy-stm32] Help enabling OCTOSPI1 memory mapped mode HOT 1
- STM32 dual core HAL init design
- Linker Issue 'cc' failed - Ubuntu 24 [duplicate symbol: _embassy_time_schedule_wake] HOT 2
- NRF missing peripheral pins HOT 2
- RP2040 timer interrupt for application use? HOT 8
- Reading Information Elements (IE) with CYW43 HOT 2
- STM32: F1 ADC does not enforce bound IRQ HOT 2
- embassy-boot can't compile with defmt feature HOT 2
- [STM32L0] TIM3 Channel 2 to PB5 remapping missing
- how to find ip by host name HOT 1
- PWM set_period issue HOT 2
- Embassy-RP and RP2040-hal Compatibility??? - Embedded_Hal::PWM:SetDutyCycle Assistance HOT 3
- Build failures after new `usbd-hid` release HOT 1
- Opamp output lifetimes slightly wrong
- Build failing due to issue in usb-hid-macros HOT 2
- Do a release of `embassy-usb`? HOT 1
- Feature Request: Cancel embassy executor task / `replace_spawn` HOT 1
- SPI flush is a noop on embassy-stm32 HOT 2
- Way to guarantee stack space HOT 3
- [embassy-stm32] allow splitting flash into banks not just regions HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from embassy.