GithubHelp home page GithubHelp logo

Comments (1)

Dirbaio avatar Dirbaio commented on September 22, 2024

Availability is there a reason why Uart::Config no have fifo: bool field?

The reasoning was, there's very little reason to not want a FIFO. Having a FIFO is just better: it makes things faster, less likely to lose bytes if you have irq delays, etc. You might think if you don't enable the FIFO you don't have to worry about flushing etc, but that's not true. You still have a 1 word "FIFO" which is the DR itself, so you can still have problems if you don't flush correctly.

Possible blocking_flush should use TXFIFO Empty flag if FIFO is enabled.

If flush() is returning before the fifo is empty with the current code then yes, definitely.

Why async flush() use blocking_flush? I think we should wait Transmission complete interrupt or TXFIFO empty interrupt

No one has implemented async flush yet, so it uses blocking flush for now, since it at least works even if not optimally. A PR fixing this would be welcome.

from embassy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.