Comments (2)
Providing a RadioKind trait with default implementations and allowing a proprietary implementation to just extend certain RadioKind trait default functions runs the risk of causing the proprietary implementation to fail if enhancements are made to the default implementations without knowledge of the ramifications to the proprietary implementation. It becomes difficult to do a semver assessment. Therefore, my current inclination is to encourage developers of a proprietary RadioKind implementation to implement all functions separately to provide isolation from minor changes to the base implementation.
However, as areas are identified where more flexibility is needed, the relevant functionality will be enhanced to allow parameterization (possibly trait-based) that enables that flexibility. Currently, the RadioKind set_oscillator() function seems ripe for better parameterization.
from lora-phy.
Addressed in v2.0.0.
from lora-phy.
Related Issues (11)
- Considering Serial Modules HOT 5
- Allow for different TCXO control voltages for 126X HOT 4
- Join failure on The Things Network using stm32wl HOT 1
- Consider upgrading for embedded-hal-async HOT 1
- Tips for inclusion in README
- Evaluate read status handling for IRQ events HOT 1
- Implement deep sleep for maximum power savings HOT 1
- LoRa Receive Soft Lock HOT 12
- index out of bounds: the len is 9 but the index is 9; HOT 3
- Allow the LoRa chip to share the SPI bus HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lora-phy.